[msbuild] Copy inputs to the remote Mac in the CompileNativeCode task.#25732
[msbuild] Copy inputs to the remote Mac in the CompileNativeCode task.#25732rolfbjarne wants to merge 1 commit into
Conversation
They may not exist on the Mac, if they were produced locally on Windows.
There was a problem hiding this comment.
Pull request overview
This PR updates the MSBuild CompileNativeCode task’s remote-build behavior so that input files produced on Windows can be copied to the remote Mac before invoking clang, addressing cases where those inputs don’t already exist on the Mac.
Changes:
- Implemented
CompileNativeCode.ShouldCopyToBuildServerto copy only existing, non-empty files to the build server (instead of never copying inputs).
| var finfo = new FileInfo (item.ItemSpec); | ||
| if (!finfo.Exists || finfo.Length == 0) | ||
| return false; |
✅ [PR Build #bf0d1ec] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #bf0d1ec] Build passed (Build packages) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [PR Build #bf0d1ec] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #bf0d1ec] Test results 🔥Test results❌ Tests failed on VSTS: test results 0 tests crashed, 4 tests failed, 216 tests passed. Failures❌ introspection tests [attempt 2]4 tests failed, 2 tests passed.Failed tests
Html Report (VSDrops) Download Successes✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
They may not exist on the Mac, if they were produced locally on Windows.