[net11.0] 'dotnet watch' works again now, so enable the corresponding tests. by rolfbjarne · Pull Request #25712 · dotnet/macios

rolfbjarne · 2026-06-17T13:14:37Z

Also a few improvements, because this test turned out rather unpredictable locally:

Detect if the build failed, and terminate the test early. The build shouldn't fail, but yet it randomly does, and this makes the test fail immediately instead of having the test time out (after a 2 min wait).
Don't give stdin to 'dotnet watch', because 'dotnet test' goes bananas. Deadlocks everywhere (dozens of threads stuck while trying to determine the cursor position in the terminal, etc).
Disable build servers. Not sure if it helps, but when random things fail, random stuff gets tried, and this won't hurt.
Don't run desktop test apps with 'open', because then the test app's process is not a descendent of the 'dotnet watch' process, and if something goes wrong and the test needs to kill 'dotnet watch', the test app won't be killed.
Always cancel the 'dotnet watch' process at the end. Copilot suggested doing this, and it sounded good so here it is.
Augment the 'Execution' class to kill the entire process tree. Once again, Copilot suggested doing this, and it sounds like a good thing to do.
Add CoreCLR mobile variations.

… tests. Also a few improvements, because this test turned out rather unpredictable locally: * Detect if the build failed, and terminate the test early. The build shouldn't fail, but yet it randomly does, and this makes the test fail immediately instead of having the test time out (after a 2 min wait). * Don't give stdin to 'dotnet watch', because 'dotnet test' goes bananas. Deadlocks everywhere (dozens of threads stuck while trying to determine the cursor position in the terminal, etc). * Disable build servers. Not sure if it helps, but when random things fail, random stuff gets tried, and this won't hurt. * Don't run desktop test apps with 'open', because then the test app's process is not a descendent of the 'dotnet watch' process, and if something goes wrong and the test needs to kill 'dotnet watch', the test app won't be killed. * Always cancel the 'dotnet watch' process at the end. Copilot suggested doing this, and it sounded good so here it is. * Augment the 'Execution' class to kill the entire process tree. Once again, Copilot suggested doing this, and it sounds like a good thing to do. * Add CoreCLR mobile variations.

rolfbjarne · 2026-06-17T13:15:19Z

/azp run

azure-pipelines · 2026-06-17T13:16:00Z

Azure Pipelines successfully started running 3 pipeline(s).

Copilot

Pull request overview

This PR re-enables and expands the dotnet watch unit tests on the net11.0 branch, while improving test reliability and process handling in the shared Execution helper used by tests/tools.

Changes:

Extend Execution to optionally close stdin for spawned processes, and to kill process trees on cancellation/timeout (where supported).
Re-enable/expand DotNetWatchTest across additional Apple platforms and add CoreCLR/Mono runtime variations.
Improve DotNetWatchTest robustness (detect initial build failures earlier, avoid stdin deadlocks, and adjust cleanup behavior).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
tools/common/Execution.cs	Adds stdin-closing option and introduces process-tree kill helper used on cancellation/timeout.
tests/dotnet/UnitTests/DotNetWatchTest.cs	Re-enables/enlarges dotnet watch coverage and hardens the test flow & cleanup.

+								Log?.WriteLine ($"Command '{p.StartInfo.FileName} {p.StartInfo.Arguments}' (pid: {pid}) was cancelled, and will be killed.");
+								KillProcess (p, pid, Log);
 							} catch (Exception ex) {


+								Log?.WriteLine ($"Command '{p.StartInfo.FileName} {p.StartInfo.Arguments}' (pid: {pid}) didn't finish in {Timeout.Value.TotalMilliseconds} ms, and will be killed.");
 								TimedOut = true;
 								try {
-									p.Kill ();
+									KillProcess (p, pid, Log);
 								} catch (Exception ex) {


+				// Wait for the app to start and show initial output
+				debugLog.WriteLine ("Waiting for app start...");
+				if (!appStarted.Task.Wait (TimeSpan.FromMinutes (1)))
+					Assert.Fail ($"Timed out waiting for the app to start. Output:\n{string.Join ("\n", output)}\nDebug output:\n{string.Join ("\n", File.ReadAllLines (debugLogPath))}");
+				debugLog.WriteLine ("App started!");


+				try {
+					debugLog.WriteLine ("Waiting for exit...");
+					watchTask.Wait (TimeSpan.FromSeconds (30));
+					debugLog.WriteLine ("Waited for exit");
+				} catch {
+					// Expected - the process was cancelled
+				}


+				debugLog.WriteLine ("Waiting for 'dotnet watch' to be waiting for changes...");
+				if (!waitingForChanges.Task.Wait (TimeSpan.FromMinutes (1)))
+					Assert.Fail ($"Timed out waiting for the 'dotnet watch' to be waiting for changes. Output:\n{string.Join ("\n", output)}\nDebug output:\n{string.Join ("\n", File.ReadAllLines (debugLogPath))}");
+				debugLog.WriteLine ("Waiting for changes!");
+				Assert.That (waitingForChanges.Task.Result, Is.True, "Build failed");


- Remove unused pid/log parameters from KillProcess. - Detect build failures early while waiting for app start, instead of timing out after 1 minute. - Move 'Waiting for changes!' log after confirming the build succeeded. - Log exceptions and timeout in cleanup path instead of swallowing them. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

vs-mobiletools-engineering-service2 · 2026-06-18T16:49:04Z

✅ [PR Build #e373f1e] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: e373f1efe69766c9837781f9797643f90080683e [PR build]

vs-mobiletools-engineering-service2 · 2026-06-18T17:00:38Z

✅ [PR Build #e373f1e] Build passed (Build packages) ✅

Pipeline on Agent
Hash: e373f1efe69766c9837781f9797643f90080683e [PR build]

vs-mobiletools-engineering-service2 · 2026-06-18T17:00:44Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: e373f1efe69766c9837781f9797643f90080683e [PR build]

vs-mobiletools-engineering-service2 · 2026-06-18T17:07:48Z

✅ [PR Build #e373f1e] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: e373f1efe69766c9837781f9797643f90080683e [PR build]

vs-mobiletools-engineering-service2 · 2026-06-18T18:50:33Z

🔥 [CI Build #e373f1e] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 36 tests failed, 169 tests passed.

Failures

❌ fsharp tests

2 tests failed, 2 tests passed.

Failed tests

fsharp/iOS - simulator/Debug: LaunchTimedOut
fsharp/tvOS - simulator/Debug: LaunchTimedOut

Html Report (VSDrops) Download

❌ introspection tests

6 tests failed, 3 tests passed.

Failed tests

introspection/iOS - simulator/Debug: LaunchTimedOut
introspection/iOS - simulator/CoreCLR: LaunchTimedOut
introspection/iOS - simulator/Debug (ARM64): LaunchTimedOut
introspection/tvOS - simulator/Debug: LaunchTimedOut
introspection/tvOS - simulator/CoreCLR: LaunchTimedOut
introspection/tvOS - simulator/Debug (ARM64): LaunchTimedOut

Html Report (VSDrops) Download

❌ monotouch tests (tvOS)

26 tests failed, 0 tests passed.

Failed tests

monotouch-test/tvOS - simulator/Debug: LaunchTimedOut
monotouch-test/tvOS - simulator/Debug (CoreCLR): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (CoreCLR, ARM64): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (CoreCLR, x64): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (CoreCLR, Universal): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (link sdk): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (link all): LaunchTimedOut
monotouch-test/tvOS - simulator/Debug (LinkSdk): LaunchTimedOut
monotouch-test/tvOS - simulator/Debug (static registrar): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (all optimizations): LaunchTimedOut
monotouch-test/tvOS - simulator/Debug (ARM64): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (NativeAOT, ARM64): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (trimmable static registrar, NativeAOT, ARM64): LaunchTimedOut
monotouch-test/tvOS - simulator/Debug (managed static registrar): LaunchTimedOut
monotouch-test/tvOS - simulator/Debug (trimmable static registrar): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (managed static registrar, all optimizations): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (trimmable static registrar, all optimizations): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (NativeAOT, x64): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (trimmable static registrar, NativeAOT, x64): LaunchTimedOut
monotouch-test/tvOS - simulator/Debug (interpreter): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (interpreter): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (compat inline Class.GetHandle): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (strict inline Class.GetHandle): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (compat inline dlfcn): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (strict inline dlfcn, link sdk): LaunchTimedOut
monotouch-test/tvOS - simulator/Release (NativeAOT, .NET 11 defaults): LaunchTimedOut

Html Report (VSDrops) Download

❌ Tests on macOS Sonoma (14) tests

2 tests failed, 3 tests passed.

Failed tests

introspection: Failed (exit code 2)
- CheckFailAttachments : System.NullReferenceException : Object reference not set to an instance of an object.
monotouch-test: Failed (exit code 2)
- No test failure details available. stderr output:
  - Got a SIGABRT while executing native code. This usually indicates
  - a fatal error in the runtime or one of the native libraries
  - used by your application.
  - make[1]: *** [exec-maccatalyst-dotnet-x64-monotouch-test] Error 134
  - sed: ../.git: No such file or directory
  - fatal: not a git repository (or any of the parent directories): .git
  - fatal: not a git repository (or any of the parent directories): .git
  - ../Make.config:218: The required Xcode (26.5) is not installed in /Applications/Xcode_26.5.0.app/Contents/Developer - this directory does not exist. Any parts of the build that require Xcode will be disabled.
  - /bin/sh: ./create-make-config.sh: No such file or directory
  - make: *** [exec-monotouch-test] Error 1

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 26 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 30 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 23 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: e373f1efe69766c9837781f9797643f90080683e [PR build]

rolfbjarne requested a review from Copilot June 17, 2026 13:14

rolfbjarne added the copilot label Jun 17, 2026

Copilot started reviewing on behalf of rolfbjarne June 17, 2026 13:15 View session

Copilot AI reviewed Jun 17, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

jonathanpeppers mentioned this pull request Jun 17, 2026

[Apple mobile] dotnet watch: XAML edits do not update the UI, C# edits crash with a Roslyn EnC NullReferenceException dotnet/maui#35928

Open

Merge branch 'net11.0' into dev/rolf/dotnet-watch-tests

327ab3e

This comment has been minimized.

Sign in to view

Conversation

rolfbjarne commented Jun 17, 2026

Uh oh!

rolfbjarne commented Jun 17, 2026

Uh oh!

azure-pipelines Bot commented Jun 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 18, 2026

✅ [PR Build #e373f1e] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jun 18, 2026

✅ [PR Build #e373f1e] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 18, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 18, 2026

✅ [PR Build #e373f1e] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jun 18, 2026

🔥 [CI Build #e373f1e] Test results 🔥

Test results

Failures

❌ fsharp tests

Failed tests

❌ introspection tests

Failed tests

❌ monotouch tests (tvOS)

Failed tests

❌ Tests on macOS Sonoma (14) tests

Failed tests

Successes

macOS tests

Linux Build Verification

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants