Skip to content

[tests] Revert workarounds for dotnet/runtime#123503. Fixes #24558.#25711

Draft
rolfbjarne wants to merge 1 commit into
net11.0from
dev/rolf/revert-runtime-123503-workarounds
Draft

[tests] Revert workarounds for dotnet/runtime#123503. Fixes #24558.#25711
rolfbjarne wants to merge 1 commit into
net11.0from
dev/rolf/revert-runtime-123503-workarounds

Conversation

@rolfbjarne

@rolfbjarne rolfbjarne commented Jun 17, 2026

Copy link
Copy Markdown
Member

Remove workarounds that were added due to dotnet/runtime#123503:

  • Remove EnableTrimAnalyzer=false, EnableAotAnalyzer=false, and NoWarn AD0001 from Directory.Build.props.
  • Remove [Ignore] attribute from BuildMyNativeAotAppWithTrimAnalysisWarning test.

Fixes #24558

🤖 Pull request created by Copilot

@rolfbjarne
Revert workarounds for dotnet/runtime#123503. Fixes #24558.
b9ce637 
The workarounds (disabling trim/AOT analyzers and suppressing AD0001
warnings) are no longer necessary now that the underlying runtime issue
has been fixed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@rolfbjarne rolfbjarne changed the base branch from main to net11.0 June 17, 2026 12:48
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

✅ [PR Build #b9ce637] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: b9ce637977495021b16db1274024c286173e1425 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

✅ [PR Build #b9ce637] Build passed (Build packages) ✅

Pipeline on Agent
Hash: b9ce637977495021b16db1274024c286173e1425 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: b9ce637977495021b16db1274024c286173e1425 [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

✅ [PR Build #b9ce637] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: b9ce637977495021b16db1274024c286173e1425 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

🔥 [CI Build #b9ce637] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 3 tests failed, 192 tests passed.

Failures

❌ introspection tests [attempt 2]

1 tests failed, 8 tests passed.

Failed tests

  • introspection/macOS/Debug: Failed (Test run failed.
    Tests run: 34 Passed: 33 Inconclusive: 0 Failed: 1 Ignored: 0)

Html Report (VSDrops) Download

❌ Tests on macOS Sonoma (14) tests [attempt 2]

2 tests failed, 3 tests passed.

Failed tests

  • introspection: Failed (exit code 2)
    • CheckFailAttachments : System.NullReferenceException : Object reference not set to an instance of an object.
  • monotouch-test: Failed (exit code 2)
    • No test failure details available. stderr output:
      • Got a SIGABRT while executing native code. This usually indicates
      • a fatal error in the runtime or one of the native libraries
      • used by your application.
      • make[1]: *** [exec-maccatalyst-dotnet-x64-monotouch-test] Error 134
      • sed: ../.git: No such file or directory
      • fatal: not a git repository (or any of the parent directories): .git
      • fatal: not a git repository (or any of the parent directories): .git
      • ../Make.config:216: The required Xcode (26.5) is not installed in /Applications/Xcode_26.5.0.app/Contents/Developer - this directory does not exist. Any parts of the build that require Xcode will be disabled.
      • /bin/sh: ./create-make-config.sh: No such file or directory
      • make: *** [exec-monotouch-test] Error 1

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 11 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 24 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 27 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 20 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 24 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: b9ce637977495021b16db1274024c286173e1425 [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

copilot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Revert workarounds due to dotnet/runtime@123503

2 participants

@rolfbjarne @vs-mobiletools-engineering-service2