Bump Microsoft.CodeAnalysis.NetAnalyzers from 9.0.0 to 10.0.301#1463
Open
dependabot[bot] wants to merge 3 commits into
Open
Bump Microsoft.CodeAnalysis.NetAnalyzers from 9.0.0 to 10.0.301#1463dependabot[bot] wants to merge 3 commits into
dependabot[bot] wants to merge 3 commits into
Conversation
--- updated-dependencies: - dependency-name: Microsoft.CodeAnalysis.NetAnalyzers dependency-version: 10.0.301 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Member
|
@copilot can you fix the errors. There are a lot! |
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Contributor
... Fixed in 64dc54b. NetAnalyzers 10.0.301 newly enables ~1,838 CA warnings across 22 rules, which break Release builds (
... Correction: the fix is in commit da48bb6. |
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Microsoft.CodeAnalysis.NetAnalyzers from 9.0.0 to 10.0.301.
NetAnalyzers 10.0.301 newly enables additional CA rules (the repo uses
AnalysisMode=AllEnabledByDefault), which break Release builds viaTreatWarningsAsErrors. Instead of suppressing these rules, the code is updated to fix the warnings across the solution:dotnet formatacross the solution.internal(CA1515) and sealed eligible internal types (CA1852) solution-wide. Verified NUnit still discovers internal test fixtures and thatgeneratorexposes internals togenerator-TestsviaInternalsVisibleTo.JavaNativeTypeManager.csusing#if NETSTANDARD2_0guards.KotlinProtobufDefinition.csvia its existing#pragma warning disable(generated file that should not be hand-edited).out varname collision from CA1854).Note: a residual set of non-autofixable rules (CA1851 multiple enumeration, CA1859 concrete types, CA1846
AsSpan, CA1867) still needs manual fixes, and final clean-build/Release/test verification remains outstanding.