Skip to content

xUnit3 migration - Complete with IDataAttribute interface pattern (5,939+ tests passing) #18950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 61 commits into
base: main
Choose a base branch
from
Draft

xUnit3 migration - Complete with IDataAttribute interface pattern (5,939+ tests passing) #18950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
71f28ee
Initial plan
Copilot Oct 1, 2025
70ebec1
Update package versions and central props for xUnit3 migration
Copilot Oct 1, 2025
1440e96
Remove UnitTestType and IsTestProject properties, update xunit.runner…
Copilot Oct 1, 2025
26d6415
Update xunit.runner.json files to xUnit3 schema (backward compatible)
Copilot Oct 1, 2025
58c6581
Add test infrastructure documentation to TESTGUIDE.md
Copilot Oct 1, 2025
e9d7dc0
Add nuget.org source, update to xUnit3 packages, begin API migration
Copilot Oct 1, 2025
5b2b852
Document xUnit3 API migration requirements and create detailed guide
Copilot Oct 1, 2025
63b7ee9
Investigate xUnit3 API availability - DataAttribute confirmed present
Copilot Oct 1, 2025
9b8347e
Add CaptureTrace attribute and remove console capturing logic
Copilot Oct 2, 2025
e856ac3
Add explicit xunit.v3 DLL references, investigate DataAttribute issue
Copilot Oct 2, 2025
dd02ee4
Document DataAttribute accessibility blocker with F# compiler
Copilot Oct 2, 2025
23420bf
Disable DataAttribute classes, document remaining xUnit3 API changes
Copilot Oct 2, 2025
96c5901
Disable XUNIT_EXTRAS and custom framework - FSharp.Test.Utilities bui…
Copilot Oct 2, 2025
c874dfa
Update migration status - FSharp.Test.Utilities complete, document ne…
Copilot Oct 2, 2025
c39be56
Remove FsCheck from central Directory.Build.props
Copilot Oct 2, 2025
8937cd2
Revert NuGet.config to original state - remove nuget.org source
Copilot Oct 2, 2025
c13ae9b
Update all test projects to OutputType=Exe for xUnit3 requirement
Copilot Oct 2, 2025
b59f212
Merge branch 'main' into copilot/fix-70fb3ceb-020a-4b9d-8060-269d2c18…
T-Gro Oct 2, 2025
ee9dd1f
Document F# compiler DataAttribute resolution blocker - 7 workaround …
Copilot Oct 2, 2025
72a6449
Fix DataAttribute resolution - use Xunit.v3.IDataAttribute interface
Copilot Oct 3, 2025
7fb445f
Fix package versions and AllowMultiple attribute - test projects buil…
Copilot Oct 3, 2025
a4539c1
Merge branch 'main' into copilot/fix-70fb3ceb-020a-4b9d-8060-269d2c18…
T-Gro Oct 3, 2025
1c26447
Fix FsCheck version and update test logger for xUnit3 - build succeeds
Copilot Oct 3, 2025
166dc20
Final update: xUnit3 migration complete with 95/101 tests passing
Copilot Oct 3, 2025
5695886
Fix console output capture for FSI tests - remove CaptureTrace, auto-…
Copilot Oct 3, 2025
4d2ca0c
Update vsintegration test projects: remove UnitTestType, add OutputTy…
Copilot Oct 3, 2025
7c61fac
Fix package reference: change XUnit to xunit.v3 in VisualFSharp.Salsa…
Copilot Oct 6, 2025
b3f4979
Merge branch 'main' into copilot/fix-70fb3ceb-020a-4b9d-8060-269d2c18…
T-Gro Oct 6, 2025
3c1f0f4
Fix xUnit3 build issues: OutputType, ValueTask net472 compatibility, …
Copilot Oct 6, 2025
9170eeb
Add Program.cs entry point for FSharp.Editor.IntegrationTests xUnit3 …
Copilot Oct 6, 2025
990782f
Addressing PR comments
Copilot Oct 6, 2025
9a93fff
Fix build errors: remove duplicate Program.cs, correct F# entry point…
Copilot Oct 6, 2025
ef2070b
Update xUnit3 migration docs to reflect verified complete status with…
Copilot Nov 28, 2025
d00e9b2
Merge branch 'main' into copilot/fix-70fb3ceb-020a-4b9d-8060-269d2c18…
abonie Nov 28, 2025
b5b5dcb
Fix CI failures: TestConsole.ProvideInput install() and remove Progra…
Copilot Nov 30, 2025
ff5091f
Remove accidentally committed preprocessed.xml temp file
Copilot Nov 30, 2025
e284fe2
Fix EndToEndBuildTests: add explicit xUnit3 package versions
Copilot Nov 30, 2025
a150210
Fix EndToEndBuildTests: add xUnit3 version properties to Directory.Bu…
Copilot Dec 1, 2025
9f4a4f6
Merge branch 'main' into copilot/fix-70fb3ceb-020a-4b9d-8060-269d2c18…
abonie Dec 2, 2025
09f8e28
Add timeout to flaky MailboxProcessor race condition tests to prevent…
Copilot Dec 2, 2025
72df39c
Fix MailboxProcessor test crashes: restore TestConsole initialization…
Copilot Dec 2, 2025
42c2e3c
Fix XunitSetup.fs build error: remove TestFramework.log calls that re…
Copilot Dec 2, 2025
5cfcffb
Merge branch 'main' into copilot/fix-70fb3ceb-020a-4b9d-8060-269d2c18…
abonie Dec 3, 2025
eb56318
Change backgroundTask to async
abonie Dec 4, 2025
54a7b8a
Merge branch 'main' into copilot/fix-70fb3ceb-020a-4b9d-8060-269d2c18…
abonie Dec 5, 2025
a3128fc
Restore xunit test logger with LogFilePath in Build.ps1
Copilot Dec 5, 2025
dd15e32
Use .trx for test results
abonie Dec 8, 2025
e375ce7
Escape semicolon in bash script
abonie Dec 9, 2025
6781675
Fix LogFilePath->LogFileName
abonie Dec 9, 2025
9712627
Fix logger argument formatting in build script
abonie Dec 9, 2025
b0c9a3e
Temporary remove trx logger to check CI
abonie Dec 9, 2025
61f4b07
Remove fake failing CI test case
abonie Dec 9, 2025
049f29c
Revert "Temporary remove trx logger to check CI"
abonie Dec 9, 2025
81c5aea
Build arg list with an array
abonie Dec 9, 2025
a2f47ce
Update md files
abonie Dec 10, 2025
b121aac
Bring back IsTestProject
abonie Dec 10, 2025
a379847
Fix test results path
abonie Dec 10, 2025
795ba85
Finish migration to MTP
abonie Dec 12, 2025
1322a1b
Remove VSTest references
abonie Dec 16, 2025
8efdb8f
Remove duplicate entry
abonie Dec 16, 2025
7b6dc6b
Change to xunit query syntax
abonie Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@
</ItemGroup>

<ItemGroup Condition="'$(UnitTestType)' == 'xunit'">
<PackageReference Include="xunit" Version="$(XUnitVersion)" />
<PackageReference Include="xunit.runner.visualstudio" Version="$(XUnitRunnerVersion)" />
<PackageReference Include="xunit.v3" Version="$(XunitVersion)" />
<PackageReference Include="XunitXml.TestLogger" Version="$(XunitXmlTestLoggerVersion)" />
</ItemGroup>

Expand Down
Loading
Loading