Skip to content

Emit N prefix for xml string literals in SQL Server #38460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+13 −1
Closed

Emit N prefix for xml string literals in SQL Server #38460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
085c604
Initial plan
Copilot Jun 18, 2026
f48bb91
Add N prefix for xml string literals in SqlServer
Copilot Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/EFCore.SqlServer/Storage/Internal/SqlServerStringTypeMapping.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,9 @@ protected SqlServerStringTypeMapping(RelationalTypeMappingParameters parameters,
_maxSize = AnsiMax;
}

_isUtf16 = parameters.Unicode && parameters.StoreType.StartsWith("n", StringComparison.OrdinalIgnoreCase);
_isUtf16 = parameters.Unicode
&& (parameters.StoreType.StartsWith("n", StringComparison.OrdinalIgnoreCase)
|| parameters.StoreType.StartsWith("xml", StringComparison.OrdinalIgnoreCase));

@ErikEJ ErikEJ Jun 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equals("xml", StringComparison.OrdinalIgnoreCase)) ?

_sqlDbType = sqlDbType;
}

Expand Down
10 changes: 10 additions & 0 deletions test/EFCore.SqlServer.Tests/Storage/SqlServerStringTypeMappingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,14 @@ public void GenerateProviderValueSqlLiteral_works_unicode(string value, string e
var mapping = new SqlServerStringTypeMapping("nvarchar(max)", unicode: true);
Assert.Equal(expected, mapping.GenerateProviderValueSqlLiteral(value));
}

[Theory, InlineData("", "N''"), InlineData("it", "N'it'"), InlineData("I'm", "N'I''m'"),
InlineData("<x Attr=\"\U0001F62D\" />", "N'<x Attr=\"\U0001F62D\" />'"),
InlineData("\n", "nchar(10)"),
InlineData("it\n", "CONCAT(CAST(N'it' AS nvarchar(max)), nchar(10))")]
public void GenerateProviderValueSqlLiteral_works_xml(string value, string expected)
{
var mapping = new SqlServerStringTypeMapping("xml", unicode: true, storeTypePostfix: StoreTypePostfix.None);
Assert.Equal(expected, mapping.GenerateProviderValueSqlLiteral(value));
}
}