Fix precompiled query generation for shadow property names that are not valid identifiers

[Copilot]

Precompiled queries derive some generated C# variable names from model metadata such as property names. Shadow properties can be given arbitrary names that are not valid C# identifiers (e.g. "NOT VALID !!!1"), producing uncompilable generated code whenever the query needs to access property metadata — for instance, a value converter on a shadow property.

modelBuilder.Entity<Blog>()
    .Property<string>("NOT VALID !!!1")
    .HasConversion<int>(x => 0, x => "");
// Generated: var nOT VALID !!!1Property = ...  // CS1003: Syntax error

Changes

• Sanitize lifted-constant variable names in LiftableConstantProcessor.LiftConstants: when a lifted constant's parameter name is not a valid identifier, the base name falls back to "unknown" (instead of being sanitized in PrecompiledQueryCodeGenerator). The existing uniquification and parameter-remapping path then keeps declarations and references in sync across the lifted constant expressions and the query executor.
• Shared identifier check: a simple, strict IsValidIdentifier helper on ModelValidator (only letters, ASCII digits and underscore, with no leading digit) is reused by both the model validator and LiftConstants. The same strict character logic is also applied to CSharpHelper.Identifier (via its IsIdentifierStartCharacter/IsIdentifierPartCharacter checks), replacing the previous broader Unicode-category handling and removing the now-unused IsLetterChar helper.
• New model-validation warning ShadowPropertyNameNotValidIdentifierWarning: fires when a shadow property name is not a valid identifier, surfaced through the standard diagnostics infrastructure (CoreEventId, CoreLoggerExtensions, LoggingDefinitions, CoreStrings).
• Tests: a reproduction precompiled-query test (relational base + Sqlite) and two ModelValidatorTest unit tests (warns on invalid name, silent on valid name). Public API additions reflected in EFCore.baseline.json.

Notes for reviewers

• The warning escalates to an error under the default test diagnostics, so the repro context suppresses it via ConfigureWarnings(...Ignore(...)) passed through InitializeNonSharedTest (DbContext pooling forbids OnConfiguring).
• Model snapshots skip ModelValidator.Validate, so the warning does not fire for snapshots.

[Copilot]

Pull request overview

This PR addresses a precompiled-query code generation failure when lifted-constant variable names are derived from shadow property names that aren’t valid C# identifiers. It adds identifier validation (with a new warning) and ensures lifted constants fall back to a safe variable base name so generated code compiles.

Changes:

• Update lifted-constant naming to fall back to "unknown" when the derived parameter name is not a valid identifier.
• Add a new model-validation warning for shadow property names that are not valid identifiers, wired through EF Core diagnostics infrastructure.
• Add tests covering both the new warning behavior and the precompiled-query repro.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
test/EFCore.Tests/Infrastructure/ModelValidatorTest.cs	Adds unit tests asserting the new shadow-property-name warning behavior.
test/EFCore.Relational.Specification.Tests/Query/AdHocPrecompiledQueryRelationalTestBase.cs	Adds a precompiled-query repro for invalid shadow property names (suppresses the new warning in the test context).
src/EFCore/Query/LiftableConstantProcessor.cs	Ensures lifted constant variable names fall back to "unknown" when invalid identifiers are encountered.
src/EFCore/Properties/CoreStrings.resx	Adds the new warning message text.
src/EFCore/Properties/CoreStrings.Designer.cs	Adds the generated resource accessor for the new warning.
src/EFCore/Infrastructure/ModelValidator.cs	Adds shadow-property name validation and an IsValidIdentifier helper used for both validation and lifting.
src/EFCore/EFCore.baseline.json	Updates the API baseline for the newly added diagnostics members.
src/EFCore/Diagnostics/LoggingDefinitions.cs	Adds a logging definition slot for the new warning.
src/EFCore/Diagnostics/CoreLoggerExtensions.cs	Adds the logger extension method for the new warning event.
src/EFCore/Diagnostics/CoreEventId.cs	Adds the new event id for the warning.

Files not reviewed (1)

• src/EFCore/Properties/CoreStrings.Designer.cs: Generated file

[AndriySvyryd]

@copilot Adjust the message

[Copilot]

Adjusted in 3a006aa.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

• src/EFCore/Properties/CoreStrings.Designer.cs: Generated file