Skip to content

Document Expression.Block ReadOnlyCollection reuse #12754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YNan-varamor wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −2
Open

Document Expression.Block ReadOnlyCollection reuse #12754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions xml/System.Linq.Expressions/Expression.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2334,6 +2334,8 @@ If the implementing method is `null`:
## Remarks
When the block expression is executed, it returns the value of the last expression in the block.

If you pass a <xref:System.Collections.ObjectModel.ReadOnlyCollection%601> instance as the `expressions` argument, the returned <xref:System.Linq.Expressions.BlockExpression> might reuse that collection instead of copying it. Do not modify the collection's underlying storage after creating the block. If the source can be mutated, create a stable snapshot before passing it to this method.
Comment thread
333fred marked this conversation as resolved.

]]></format>
</remarks>
</Docs>
Expand Down Expand Up @@ -2463,6 +2465,8 @@ If the implementing method is `null`:
## Remarks
When the block expression is executed, it returns the value of the last expression in the block.

If you pass a <xref:System.Collections.ObjectModel.ReadOnlyCollection%601> instance as the `expressions` argument, the returned <xref:System.Linq.Expressions.BlockExpression> might reuse that collection instead of copying it. Do not modify the collection's underlying storage after creating the block. If the source can be mutated, create a stable snapshot before passing it to this method.
Comment thread
333fred marked this conversation as resolved.



## Examples
Expand Down Expand Up @@ -2696,7 +2700,14 @@ If the implementing method is `null`:
<param name="expressions">The expressions in the block.</param>
<summary>Creates a <see cref="T:System.Linq.Expressions.BlockExpression" /> that contains the given expressions, has no variables and has specific result type.</summary>
<returns>The created <see cref="T:System.Linq.Expressions.BlockExpression" />.</returns>
<remarks>To be added.</remarks>
<remarks>
<format type="text/markdown"><![CDATA[

## Remarks
If you pass a <xref:System.Collections.ObjectModel.ReadOnlyCollection%601> instance as the `expressions` argument, the returned <xref:System.Linq.Expressions.BlockExpression> might reuse that collection instead of copying it. Do not modify the collection's underlying storage after creating the block. If the source can be mutated, create a stable snapshot before passing it to this method.

]]></format>
</remarks>
Comment on lines +2703 to +2710

@333fred 333fred Jun 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YNan-varamor please address this comment. The other comments are bogus, but this is correct.

</Docs>
</Member>
<Member MemberName="Block">
Expand Down Expand Up @@ -2809,7 +2820,14 @@ If the implementing method is `null`:
<param name="expressions">The expressions in the block.</param>
<summary>Creates a <see cref="T:System.Linq.Expressions.BlockExpression" /> that contains the given variables and expressions.</summary>
<returns>The created <see cref="T:System.Linq.Expressions.BlockExpression" />.</returns>
<remarks>To be added.</remarks>
<remarks>
<format type="text/markdown"><![CDATA[

## Remarks
If you pass a <xref:System.Collections.ObjectModel.ReadOnlyCollection%601> instance as the `expressions` argument, the returned <xref:System.Linq.Expressions.BlockExpression> might reuse that collection instead of copying it. Do not modify the collection's underlying storage after creating the block. If the source can be mutated, create a stable snapshot before passing it to this method.
Comment thread
333fred marked this conversation as resolved.

]]></format>
</remarks>
</Docs>
</Member>
<Member MemberName="Block">
Expand Down
Loading