-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Clarify Type.FullName and Type.AssemblyQualifiedName null return conditions #12106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clarify null return conditions Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Type.FullName behavior to match documentation
Clarify Type.FullName and Type.AssemblyQualifiedName null return conditions
Dec 5, 2025
Copilot finished work on behalf of
jkotas
December 5, 2025 14:22
jkotas
approved these changes
Dec 5, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR corrects the documentation for Type.FullName and Type.AssemblyQualifiedName to accurately reflect their runtime behavior regarding when they return null.
- Removes incorrect claims that these properties return null for array types and pointer types
- Updates documentation to clarify that null is returned when the type can't be represented by a fully qualified name, specifically for types with unresolved generic parameters (
ContainsGenericParametersis true) and types containing function pointers - Ensures both properties have consistent and accurate documentation
Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
jkotas
approved these changes
Dec 5, 2025
Copilot finished work on behalf of
jkotas
December 5, 2025 14:51
gewarren
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The documentation incorrectly stated that
Type.FullNameandType.AssemblyQualifiedNamereturn null for array types and pointer types. Actual runtime behavior shows they return non-null values for these types:Changes:
Type.FullNamedocumentation to clarify it returns null when "the type can't be represented by a fully qualified name" - specifically for types with unresolved generic parameters (ContainsGenericParametersis true) and types containing function pointersType.AssemblyQualifiedNamedocumentation with the same clarificationOriginal prompt
Type.FullNamebehavior diverges from documentation #12104💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.