Skip to content

Add ImageUrl to regexes #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gewarren merged 3 commits into from
Mar 30, 2026
+5 −2
Merged

Add ImageUrl to regexes #650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35e65e3
add imageUrl to _imageLineRegExes and regex for replacing site relat…
mestew Mar 27, 2026
eb2866f
add changes to program.cs for site relative
mestew Mar 27, 2026
88999b6
combine imageSrc and imageUrl into one regex
mestew Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cleanrepo/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,8 +501,9 @@ private static void ReplaceLinks(List<FileInfo> linkingFiles, string urlBasePath
@"\]:\s(/" + urlBasePath + @"/([^\s]*))", // [ref link]: /basepath/some other text
"<img[^>]*?src[ ]*=[ ]*\"(/" + urlBasePath + "/([^>]*?.(png|gif|jpg|svg)))[ ]*\"", // <img src="/azure/mydocs/media/pic3.png">
@"\[.*\]:[ ]*(/" + urlBasePath + @"/(.*\.(png|gif|jpg|svg)))", // [0]: /azure/mydocs/media/pic1.png
@"imageSrc:[ ]*(/" + urlBasePath + @"/([^:]*\.(png|gif|jpg|svg)))", // imageSrc: /azure/mydocs/media/pic1.png
@"image(?:Src|Url):\s*(/" + urlBasePath + @"/([^:]*\.(png|gif|jpg|svg)))", // imageSrc: /azure/mydocs/media/pic1.png or imageUrl: /azure/mydocs/media/pic1.png
@":::image[^:]*source=""(/" + urlBasePath + @"/([^:]*\.(png|gif|jpg|svg)))""[^:]*:::" // :::image type="complex" source="/azure/mydocs/media/pic1.png" alt-text="Screenshot.":::

];

foreach (FileInfo linkingFile in linkingFiles)
Expand Down
4 changes: 3 additions & 1 deletion cleanrepo/Repo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,13 @@ class DocFxRepo(string startDirectory, string urlBasePath)
@"!\[.*?\]\((?<path>.*?(\.(png|jpg|gif|svg))+)", // ![hello](media/how-to/xamarin.png)
"<img[^>]*?src[ ]*=[ ]*[\"'](?<path>[^>]*?(\\.(png|gif|jpg|svg))+)[ ]*[\"']", // <img data-hoverimage="./images/start.svg" src="./images/start.png" alt="Start icon" />
@"\[.*\]:(?<path>.*?(\.(png|gif|jpg|svg))+)", // [0]: ../../media/how-to/xamarin.png
@"imageSrc:(?<path>[^:]*?(\.(png|gif|jpg|svg))+)", // imageSrc: ./media/vs-mac.svg
@"image(Src|Url):(?<path>[^:]*?(\.(png|gif|jpg|svg))+)", // imageSrc: ./media/vs-mac.svg or imageUrl: ./media/vs-mac.svg
@"thumbnailUrl: (?<path>.*?(\.(png|gif|jpg|svg))+)", // thumbnailUrl: /thumbs/two-forest.png
"lightbox\\s*=\\s*\"(?<path>.*?(\\.(png|gif|jpg|svg))+)\"", // lightbox="media/azure.png"
":::image [^:]*?source\\s*=\\s*\"(?<path>.*?(\\.(png|gif|jpg|svg))+)(\\?[\\w\\s=\\.]+)?\\s*\"", // :::image type="content" source="media/publish.png?text=Publish dialog." alt-text="Publish dialog.":::
"<a href=\"(?<path>[^\"]*?(\\.(png|gif|jpg|svg))+)\"", // <a href="./media/job-large.png" target="_blank"><img src="./media/job-small.png"></a>
"\\]\\((?<path>[^\\)]*?(\\.(png|jpg|gif|svg)))+(#lightbox)[\\s|\\)]" //](../images/alignment-expansion-large.png#lightbox)

];
private List<FileInfo>? _allMdAndYmlFiles;
private List<FileInfo>? AllMdAndYmlFiles
Expand Down Expand Up @@ -214,6 +215,7 @@ internal void OutputImageReferences(bool ocrImages = false, bool filteredOcrImag
/// ![Architecture] (./media/ci-cd-flask/Architecture.PNG? raw = true)
/// The Light Bulb icon ![Small Light Bulb Icon] (media/vs2015_lightbulbsmall.png "VS2017_LightBulbSmall")
/// imageSrc: ./media/vs-mac-2019.svg
/// imageUrl: media/microsoft-365-copilot-hub/copilot-hub-work-1.jpg
/// <img src="/azure/mydocs/media/pic3.png" alt="Work Backlogs page shortcuts"/>
/// [0]: ../../media/vs-acr-provisioning-dialog-2019.png
/// :::image type = "complex" source="./media/seedwork-classes.png" alt-text="Screenshot of the SeedWork folder.":::
Expand Down
Loading