dotnet-dump and dotnet-symbol returns 407 behind a proxy#5478
Open
ladeak wants to merge 2 commits intodotnet:mainfrom
Open
dotnet-dump and dotnet-symbol returns 407 behind a proxy#5478ladeak wants to merge 2 commits intodotnet:mainfrom
ladeak wants to merge 2 commits intodotnet:mainfrom
Conversation
…ding symbols. Setting the default network credentials before HttpClient is set. Optionally HttpSymbolStore could create a custom HttpClientHandler, but based on the remarks https://learn.microsoft.com/en-us/dotnet/api/system.net.http.httpclienthandler.usedefaultcredentials?view=net-9.0 this is only desired for client applications, while not sure how this project is used otherwise.
ladeak
commented
May 8, 2025
mikem8361
reviewed
May 9, 2025
ladeak
force-pushed
the
httpclient-defaultnetworkcredentials
branch
from
6d8b50c to
fe89400
Compare
ladeak
force-pushed
the
httpclient-defaultnetworkcredentials
branch
from
fe89400 to
c9cb4c9
Compare
ladeak
commented
May 9, 2025
|
|
||
| // Create client | ||
| _client = new HttpClient | ||
| #if NETSTANDARD2_0 |
Author
There was a problem hiding this comment.
I believe this is enough, but I can only fully test it on Monday.
and
Proxy is left default, UseProxy is set to true, DefaultProxyCredentials set.
EDIT I find this change more risky. HttpClientHandler has different behavior on .net462, .net8, .net9.
Author
|
@mikem8361 - any suggestions? |
Contributor
|
@hoyosjs can you look at this? |
Author
|
@mikem8361 or @hoyosjs could you please have a look? |
Member
|
@ladeak - sorry. I thought I had responded. There should be no behavioral difference between TFMs and that will block this PR. As for the proxy behavior - this is changing a library that is not just used by the tools, and this might not be the desired behavior outside of client workflows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet-dump and dotnet-symbol returns HTTP 407 status code behind a proxy when downloading symbols. Setting the default network credentials before
HttpClientis created. OptionallyHttpSymbolStorecould create a customHttpClientHandlertoo (different solution because of netstandard2.0), but based on the remarks this is only desired for client applications. I am not sure how this Microsoft.SymbolStore project is used otherwise. Hence, dotnet-dump and dotnet-symbol sets the default proxy credentials before creating aHttpSymbolStore.