You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My goal was to port these changes over, but I figured according to the documentation, the intent is to maintain a mirror, so I just copied all files over and see what happens.
No wonder - it won't compile - what should we do here?
@brianrob. It appears that some changes are good to have (e.g. the very large graph support, the gen4 support). However, the new version accessed types cannot be accessed here. Do you have some idea what shall we do with that?
@cshung I don't recall why, but these files are copied from the perfview repo. There have been a number of changes that likely impact other files (e.g. there is a new type called SerializationConfiguration, a new enum called StreamLabelWidth). Perhaps it would be worth revisiting if the TraceEvent NuGet package can be used directly, or what it would take to get there. Alternatively, you'll have to go through each of these errors and figure out which files are missing - for example SerializationConfiguration is part of FastSerialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a work in progress.
My goal was to port these changes over, but I figured according to the documentation, the intent is to maintain a mirror, so I just copied all files over and see what happens.
No wonder - it won't compile - what should we do here?