Skip to content

Normalize enum names to lowercase in graphminimalpermissionsplugin schema#1524

Open
waldekmastykarz wants to merge 1 commit intodotnet:mainfrom
waldekmastykarz:fix/enum-names-schema
Open

Normalize enum names to lowercase in graphminimalpermissionsplugin schema#1524
waldekmastykarz wants to merge 1 commit intodotnet:mainfrom
waldekmastykarz:fix/enum-names-schema

Conversation

@waldekmastykarz
Copy link
Collaborator

No description provided.

@waldekmastykarz waldekmastykarz added the pr-bugfix Fixes a bug label Feb 7, 2026
@waldekmastykarz waldekmastykarz requested a review from a team as a code owner February 7, 2026 10:58
Copilot AI review requested due to automatic review settings February 7, 2026 10:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the JSON schemas for GraphMinimalPermissionsPlugin across multiple versioned schema folders to use lowercase enum values for the type setting, aligning the schema with the lowercase values used in configuration samples and (likely) runtime enum serialization conventions.

Changes:

  • Changed type enum values from "Delegated"/"Application" to "delegated"/"application" in multiple schema versions.
  • Updated the type property description (where present) to reference lowercase values and default.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
schemas/v2.1.0/graphminimalpermissionsplugin.schema.json Lowercases type enum values and updates description/default text.
schemas/v2.0.0/graphminimalpermissionsplugin.schema.json Lowercases type enum values and updates description/default text.
schemas/v1.3.0/graphminimalpermissionsplugin.schema.json Lowercases type enum values and updates description/default text.
schemas/v1.2.1/graphminimalpermissionsplugin.schema.json Lowercases type enum values and updates description/default text.
schemas/v1.2.0/graphminimalpermissionsplugin.schema.json Lowercases type enum values and updates description/default text.
schemas/v1.1.0/graphminimalpermissionsplugin.schema.json Lowercases type enum values and updates description/default text.
schemas/v1.0.0/graphminimalpermissionsplugin.schema.json Lowercases type enum values and updates description/default text.
schemas/v0.29.2/graphminimalpermissionsplugin.schema.json Lowercases type enum values and updates description/default text.
schemas/v0.29.1/graphminimalpermissionsplugin.schema.json Lowercases type enum values and updates description/default text.
schemas/v0.29.0/graphminimalpermissionsplugin.schema.json Lowercases type enum values and updates description/default text.
schemas/v0.28.0/graphminimalpermissionsplugin.schema.json Lowercases type enum values and updates description/default text.
schemas/v0.27.0/graphminimalpermissionsplugin.schema.json Lowercases type enum values and updates description/default text.
schemas/v0.26.0/graphminimalpermissionsplugin.schema.json Lowercases type enum values (no description in this schema version).
schemas/v0.25.0/graphminimalpermissionsplugin.schema.json Lowercases type enum values (no description in this schema version).

"Delegated",
"Application"
"delegated",
"application"
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).

Suggested change
"application"
"application",
"Delegated",
"Application"

Copilot uses AI. Check for mistakes.
"Delegated",
"Application"
"delegated",
"application"
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).

Suggested change
"application"
"Delegated",
"application",
"Application"

Copilot uses AI. Check for mistakes.
"Delegated",
"Application"
"delegated",
"application"
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).

Suggested change
"application"
"Delegated",
"application",
"Application"

Copilot uses AI. Check for mistakes.
"Delegated",
"Application"
"delegated",
"application"
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).

Suggested change
"application"
"Delegated",
"application",
"Application"

Copilot uses AI. Check for mistakes.
Comment on lines 12 to +16
"enum": [
"Delegated",
"Application"
"delegated",
"application"
],
"description": "Determines which type of permission scopes to return. Can be 'Delegated' or 'Application'. Default: 'Delegated'."
"description": "Determines which type of permission scopes to return. Can be 'delegated' or 'application'. Default: 'delegated'."
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).

Copilot uses AI. Check for mistakes.
"Delegated",
"Application"
"delegated",
"application"
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).

Suggested change
"application"
"Delegated",
"application",
"Application"

Copilot uses AI. Check for mistakes.
Comment on lines 12 to +16
"enum": [
"Delegated",
"Application"
"delegated",
"application"
],
"description": "Determines which type of permission scopes to return. Can be 'Delegated' or 'Application'. Default: 'Delegated'."
"description": "Determines which type of permission scopes to return. Can be 'delegated' or 'application'. Default: 'delegated'."
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).

Copilot uses AI. Check for mistakes.
"Delegated",
"Application"
"delegated",
"application"
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).

Suggested change
"application"
"Delegated",
"application",
"Application"

Copilot uses AI. Check for mistakes.
"Delegated",
"Application"
"delegated",
"application"
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).

Suggested change
"application"
"application",
"Delegated",
"Application"

Copilot uses AI. Check for mistakes.
"Delegated",
"Application"
"delegated",
"application"
Copy link

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schema enum now only permits lowercase values ('delegated'/'application'). This is a breaking change for configs (and editor validation) that still use the previously-documented 'Delegated'/'Application' values, especially for people pinning older schema URLs. Consider allowing both casings in the enum (or introducing a new schema version and leaving historical schemas unchanged).

Suggested change
"application"
"application",
"Delegated",
"Application"

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant