Add IsStdioMode property and update plugin URL validation logic. Closes #1519#1523
Open
waldekmastykarz wants to merge 1 commit intodotnet:mainfrom
Open
Add IsStdioMode property and update plugin URL validation logic. Closes #1519#1523waldekmastykarz wants to merge 1 commit intodotnet:mainfrom
waldekmastykarz wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes plugin loading failures for devproxy stdio runs when no urlsToWatch are configured, aligning plugin URL validation with STDIO/JSON-RPC usage (closes #1519).
Changes:
- Adds
IsStdioModeto early-parsed CLI options to detectstdioinvocation. - Updates plugin registration to only enforce “at least one URL to watch” when not running in STDIO mode.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| DevProxy/Plugins/PluginServiceExtensions.cs | Passes STDIO mode into plugin registration and skips URL-to-watch enforcement when running in STDIO mode. |
| DevProxy/Commands/DevProxyConfigOptions.cs | Introduces IsStdioMode based on the parsed subcommand name (stdio). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IsStdioMode property and update plugin URL validation logic. Closes #1519