let the users provide MaxWidth via HelpAction#2635
Merged
adamsitnik merged 1 commit intodotnet:mainfrom Jul 22, 2025
Merged
Conversation
This was referenced Jul 22, 2025
baronfel
approved these changes
Jul 22, 2025
Member
baronfel
left a comment
baronfel
left a comment
There was a problem hiding this comment.
Based on dotnet/diagnostics#5493 (comment) this seems like a reasonable way to go - but my expectation is that if someone did want to override this value, they'd have to
- ensure the default help option was not added to the tree
- create their own help option
- assign that help option a customized HelpAction using this new API
is that correct?
Member
Author
That is correct. It takes some effort to do it, but I expect it to be rare. |
hoyosjs
reviewed
Jul 23, 2025
| { | ||
| try | ||
| { | ||
| _maxWidth = Console.IsOutputRedirected ? int.MaxValue : Console.WindowWidth; |
Member
There was a problem hiding this comment.
Will something cause reevaluation on resizing the console host?
Member
Author
There was a problem hiding this comment.
Will something cause reevaluation on resizing the console host?
No. This value will be requested a moment before the help is going to be displayed. And in 99.9% of the cases that will be the last thing the program does before exit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: dotnet/diagnostics#5493 (comment)