[testing] Bump R8 to 9.1.43#11688
Draft
jonathanpeppers wants to merge 1 commit into
Draft
Conversation
Picks up the fix for a NullPointerException in `AndroidApiLevelCompute.of()` that triggers when R8 is invoked with `--no-tree-shaking`. Because 9.1.43 has not yet been published to maven.google.com, `src/r8/build.gradle` now also pulls from the R8 release feed at https://storage.googleapis.com/r8-releases/raw, as described in https://r8.googlesource.com/r8/#replacing-r8-in-agp. See: * https://issuetracker.google.com/issues/524775142 * #11672 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the R8/D8 shipped in .NET for Android from
9.1.31→9.1.43.Why
R8
9.1.31throws aNullPointerExceptioninAndroidApiLevelCompute.of()when invoked with--no-tree-shaking. Google's R8 team fixed this in9.1.43.How
9.1.43is a stable tagged R8 release, but it has not yet been published tomaven.google.com(which still tops out at9.1.31). It is published on the R8 team's own release feed athttps://storage.googleapis.com/r8-releases/raw, which is the channel Google's R8 docs point users at for exactly this case — see Replacing R8 in AGP.src/r8/build.gradlenow:https://storage.googleapis.com/r8-releases/rawas a maven repository (aftergoogle()andmavenCentral(), so Google Maven is still preferred when a version is available there).com.android.tools:r8:9.1.43.Verification
Built locally via the existing gradle build that backs
src/r8/r8.csproj:And confirmed the produced fat-jar reports the right version: