Enable real signing on main branch#1475
Open
jonathanpeppers wants to merge 2 commits into
Open
Conversation
Real signing previously only triggered for release/* branches. Add main to the condition so non-PR builds of main also produce signed artifacts, enabling shipping directly from main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the Azure Pipelines signing stage so that non–Pull Request builds from main (in addition to release/*) request real signing, enabling release-quality artifacts to be produced directly from main.
Changes:
- Expand the
signType: Realcondition to includerefs/heads/mainfor non-PR runs. - Keep
signType: Testfor all PR-triggered builds (viaBuild.Reasoncheck).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
build/ci/stage-sign-artifacts.ymlonly requestssignType: Realfor non-PR builds ofrelease/*branches; everything else (includingmain) signs withTest. To enable shipping directly out ofmain, this expands the condition so non-PR builds ofmainalso produce real-signed artifacts.PR builds remain test-signed regardless of target branch.