WIP Fix MediaContent-related API not being generated #1356
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -111,4 +111,9 @@ | |||||||||
| Google.Ads.Nonagon.Util.Logging.Csi | ||||||||||
| </attr> | ||||||||||
|
|
||||||||||
| <!-- MediaContent API bindings --> | ||||||||||
| <!-- Remove obfuscated methods from MediaContent interface that reference internal types --> | ||||||||||
| <remove-node path="/api/package[@name='com.google.android.gms.ads']/interface[@name='MediaContent']/method[@name='zza']" /> | ||||||||||
| <remove-node path="/api/package[@name='com.google.android.gms.ads']/interface[@name='MediaContent']/method[@name='zzb']" /> | ||||||||||
|
|
||||||||||
|
Comment on lines
+114
to
+118
There was a problem hiding this comment. In this Metadata.xml you already have a global
Suggested change
Member
There was a problem hiding this comment. @marius-bughiu this is kind of what I thought as well, do the new |
||||||||||
| </metadata> | ||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,6 +72,13 @@ KotlinX.AtomicFU.Locks.ParkingSupport.ParkUntil(Kotlin.Time.ITimeMark! deadline) | |
| KotlinX.AtomicFU.Locks.ParkingSupport.Unpark(Java.Lang.Thread! handle) -> void | ||
| KotlinX.AtomicFU.Locks.ParkingSupportKt | ||
| KotlinX.AtomicFU.Locks.SynchronizedKt | ||
| KotlinX.AtomicFU.Locks.SynchronousMutex | ||
| KotlinX.AtomicFU.Locks.SynchronousMutex.Lock() -> void | ||
| KotlinX.AtomicFU.Locks.SynchronousMutex.SynchronousMutex() -> void | ||
| KotlinX.AtomicFU.Locks.SynchronousMutex.TryLock() -> bool | ||
| KotlinX.AtomicFU.Locks.SynchronousMutex.TryLock(long timeout) -> bool | ||
| KotlinX.AtomicFU.Locks.SynchronousMutex.Unlock() -> void | ||
| KotlinX.AtomicFU.Locks.SynchronousMutexKt | ||
|
Comment on lines
+75
to
+81
There was a problem hiding this comment. These KotlinX.AtomicFU PublicAPI baseline additions (new |
||
| KotlinX.AtomicFU.MangledJsNamesKt | ||
| KotlinX.AtomicFU.TraceBase | ||
| KotlinX.AtomicFU.TraceBase.None | ||
|
|
@@ -96,6 +103,8 @@ override KotlinX.AtomicFU.Locks.ParkingDelegatorKt.JniPeerMembers.get -> Java.In | |
| override KotlinX.AtomicFU.Locks.ParkingSupport.JniPeerMembers.get -> Java.Interop.JniPeerMembers! | ||
| override KotlinX.AtomicFU.Locks.ParkingSupportKt.JniPeerMembers.get -> Java.Interop.JniPeerMembers! | ||
| override KotlinX.AtomicFU.Locks.SynchronizedKt.JniPeerMembers.get -> Java.Interop.JniPeerMembers! | ||
| override KotlinX.AtomicFU.Locks.SynchronousMutex.JniPeerMembers.get -> Java.Interop.JniPeerMembers! | ||
| override KotlinX.AtomicFU.Locks.SynchronousMutexKt.JniPeerMembers.get -> Java.Interop.JniPeerMembers! | ||
| override KotlinX.AtomicFU.MangledJsNamesKt.JniPeerMembers.get -> Java.Interop.JniPeerMembers! | ||
| override KotlinX.AtomicFU.TraceBase.JniPeerMembers.get -> Java.Interop.JniPeerMembers! | ||
| override KotlinX.AtomicFU.TraceBase.None.JniPeerMembers.get -> Java.Interop.JniPeerMembers! | ||
|
|
@@ -132,6 +141,7 @@ static KotlinX.AtomicFU.AtomicFU_commonKt.UpdateAndGet(KotlinX.AtomicFU.AtomicIn | |
| static KotlinX.AtomicFU.AtomicFU_commonKt.UpdateAndGet(KotlinX.AtomicFU.AtomicLong! obj, Kotlin.Jvm.Functions.IFunction1! function) -> long | ||
| static KotlinX.AtomicFU.AtomicFU_commonKt.UpdateAndGet(KotlinX.AtomicFU.AtomicRef! obj, Kotlin.Jvm.Functions.IFunction1! function) -> Java.Lang.Object? | ||
| static KotlinX.AtomicFU.Locks.ParkingSupport.Instance.get -> KotlinX.AtomicFU.Locks.ParkingSupport! | ||
| static KotlinX.AtomicFU.Locks.SynchronousMutexKt.WithLock(KotlinX.AtomicFU.Locks.SynchronousMutex! obj, Kotlin.Jvm.Functions.IFunction0! block) -> Java.Lang.Object? | ||
| static KotlinX.AtomicFU.TraceBase.None.Instance.get -> KotlinX.AtomicFU.TraceBase.None! | ||
| static KotlinX.AtomicFU.TraceKt.Named(KotlinX.AtomicFU.TraceBase! obj, string! name) -> KotlinX.AtomicFU.TraceBase! | ||
| static KotlinX.AtomicFU.TraceKt.Trace(int size, KotlinX.AtomicFU.TraceFormat! format) -> KotlinX.AtomicFU.TraceBase! | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -228,6 +228,7 @@ KotlinX.Serialization.MissingFieldException.MissingFieldException(System.Collect | |
| KotlinX.Serialization.MissingFieldException.MissingFieldException(System.Collections.Generic.IList<string!>! missingFields, string? message, Java.Lang.Throwable? cause) -> void | ||
| KotlinX.Serialization.MissingFieldException.MissingFieldException(string! missingField, string! serialName) -> void | ||
| KotlinX.Serialization.MissingFieldException.MissingFields.get -> System.Collections.Generic.IList<string!>! | ||
| KotlinX.Serialization.MissingFieldException.SerialName.get -> string? | ||
| KotlinX.Serialization.Modules.ISerializersModuleCollector | ||
|
Comment on lines
228
to
232
There was a problem hiding this comment. These PublicAPI baseline additions for KotlinX.Serialization (e.g., |
||
| KotlinX.Serialization.Modules.ISerializersModuleCollector.Contextual(Kotlin.Reflect.IKClass! kClass, Kotlin.Jvm.Functions.IFunction1! provider) -> void | ||
| KotlinX.Serialization.Modules.ISerializersModuleCollector.Contextual(Kotlin.Reflect.IKClass! kClass, KotlinX.Serialization.IKSerializer! serializer) -> void | ||
|
|
@@ -239,6 +240,7 @@ KotlinX.Serialization.Modules.PolymorphicModuleBuilder | |
| KotlinX.Serialization.Modules.PolymorphicModuleBuilder.Default(Kotlin.Jvm.Functions.IFunction1! defaultSerializerProvider) -> void | ||
| KotlinX.Serialization.Modules.PolymorphicModuleBuilder.DefaultDeserializer(Kotlin.Jvm.Functions.IFunction1! defaultDeserializerProvider) -> void | ||
| KotlinX.Serialization.Modules.PolymorphicModuleBuilder.Subclass(Kotlin.Reflect.IKClass! subclass, KotlinX.Serialization.IKSerializer! serializer) -> void | ||
| KotlinX.Serialization.Modules.PolymorphicModuleBuilder.SubclassesOfSealed(KotlinX.Serialization.IKSerializer! serializer) -> void | ||
| KotlinX.Serialization.Modules.PolymorphicModuleBuilderKt | ||
| KotlinX.Serialization.Modules.SerializersModule | ||
| KotlinX.Serialization.Modules.SerializersModule.SerializersModule(nint javaReference, Android.Runtime.JniHandleOwnership transfer) -> void | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR changes the public API baseline for play-services-ads-identifier by swapping the
Zza/Zzcsignatures. This isn’t mentioned in the PR description and seems unrelated to the MediaContent binding fix; please confirm it’s intentional (and backed by updated bindings) or revert/split it to avoid accidental API churn.