-
Notifications
You must be signed in to change notification settings - Fork 330
Thread assembly signing through CI pipelines and add signed IVT for extension projects #4369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
paulmedynski
wants to merge
12
commits into
main
Choose a base branch
from
dev/paul/abstractions-strong-name-check
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4cc21a6
pipeline: extract download-assembly-signing-key template and wire sig…
paulmedynski 37d6dfa
src: add conditional signed IVT and TestSigningKeyPath to extension p…
paulmedynski 28efdb5
test: add Logging.Test project and CI pipeline coverage
paulmedynski 7889797
Renamed STRONG_NAME_SIGNING to ASSEMBLY_SIGNING, and all similar term…
paulmedynski 659d1ec
fix: address PR #4369 review feedback
paulmedynski 60edf88
fix: use compile-time branches for pack buildProperties to avoid MSB1005
paulmedynski a49e846
Pass SigningKeyPathArgument to test targets and normalize DotnetComma…
paulmedynski 84d437a
Disable signing for Project-mode pipeline; add signing to SqlServer.S…
paulmedynski 44ae0f7
Disable signing for leaf packages in Project-mode pipeline
paulmedynski 8668069
Disable signing for Azure Extensions pack job in Project mode
paulmedynski 5b5ff12
Gate test job signing on referenceType for leaf packages
paulmedynski 240ea7e
Address PR #4369 review feedback
paulmedynski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added consistent sections and ordering to these command builders.