Skip to content

Conversation

@cheenamalhotra
Copy link
Member

This PR improves tracing in Managed SNI to capture continuation events, errors, etc. This is helpful for investigating delays, timeouts in a heavy-loaded application.

Also fixed the SNIPacket constructor to initialize with physical handle reference.

Copilot AI review requested due to automatic review settings December 22, 2025 19:52
@cheenamalhotra cheenamalhotra requested a review from a team as a code owner December 22, 2025 19:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances diagnostic tracing in Managed SNI by enabling trace events in release builds and fixing the SNIPacket constructor initialization. The changes aim to improve observability in production environments by capturing continuation events, errors, and connection-related information during heavy-load scenarios.

  • Added trace event in ReadAsyncCallback to track when the callback is entered
  • Modified SNIPacket constructor calls in non-DEBUG builds to include physical handle reference
  • Removed DEBUG conditional compilation from several trace events to enable production tracing

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
TdsParserStateObject.cs Added trace event to log entry into ReadAsyncCallback for improved diagnostics
SniPhysicalHandle.netcore.cs Changed SNIPacket constructor call in non-DEBUG builds to pass physical handle and id parameters
SniPacket.netcore.cs Removed DEBUG guards from trace events to enable tracing in release builds

@paulmedynski paulmedynski self-assigned this Dec 22, 2025
@cheenamalhotra cheenamalhotra merged commit 3608731 into main Dec 23, 2025
244 of 249 checks passed
@cheenamalhotra cheenamalhotra deleted the dev/cheena/managed-sni-improv branch December 23, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants