Solve UI library react/typescript performance issues#3077
Draft
Solve UI library react/typescript performance issues#3077
Conversation
jotjern
force-pushed
the
ui-lib-performance-improvements
branch
from
da7c2b2 to
12b4e95
Compare
junlarsen
reviewed
Apr 5, 2026
| * component from 'next/link' to create a link that looks like a button | ||
| */ | ||
| element?: E | ||
| export type ButtonProps = VariantProps<typeof button> & |
Member
There was a problem hiding this comment.
This breaks the types for polymorphic components so I don't quite know if we should do this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.