Conversation
junlarsen
requested changes
Mar 10, 2026
Member
junlarsen
left a comment
junlarsen
left a comment
There was a problem hiding this comment.
Keep the url state as a zod schema preferably https://nuqs.dev/docs/parsers/community/zod-codecs
I do however think that this isn't really the right direction to do form-url syncing. I can show you tomorrow @andrefkl
junlarsen
requested changes
Mar 11, 2026
Comment on lines
+305
to
+307
| const submitEventTabsForm = eventTabsForm.handleSubmit(({ eventListTab }) => { | ||
| router.replace(`?eventListTab=${eventListTab}`, { scroll: false }) | ||
| }) |
Member
There was a problem hiding this comment.
Better way to handle this is to make the form not submittable, and instead just do it on change with subscribe()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can use nuqs later to clean up the event filter states etc and add more state to the url in other places