Draft
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
brage-andreas
changed the title
brage-andreas
force-pushed
the
add-manual-auth0-user-linking
branch
from
a8811c8 to
fe06e48
Compare
brage-andreas
force-pushed
the
add-manual-auth0-user-linking
branch
2 times, most recently
from
f169dfd to
7842ec9
Compare
brage-andreas
force-pushed
the
add-manual-auth0-user-linking
branch
2 times, most recently
from
c01d5c2 to
4490656
Compare
brage-andreas
force-pushed
the
add-manual-auth0-user-linking
branch
2 times, most recently
from
4a9689f to
bcc80e8
Compare
brage-andreas
force-pushed
the
add-manual-auth0-user-linking
branch
from
bcc80e8 to
fee41b0
Compare
brage-andreas
changed the base branch from
graphite-base/2859
to
remove-feide-account-linker-from-terraform
This was referenced Mar 29, 2026
brage-andreas
force-pushed
the
add-manual-auth0-user-linking
branch
from
fee41b0 to
a3bffc0
Compare
brage-andreas
changed the base branch from
remove-feide-account-linker-from-terraform
to
graphite-base/2859
brage-andreas
force-pushed
the
add-manual-auth0-user-linking
branch
from
a3bffc0 to
24b647e
Compare
brage-andreas
force-pushed
the
graphite-base/2859
branch
from
75de729 to
4080a05
Compare
brage-andreas
force-pushed
the
add-manual-auth0-user-linking
branch
from
24b647e to
4c19692
Compare
brage-andreas
force-pushed
the
graphite-base/2859
branch
from
979017c to
dadd38e
Compare
brage-andreas
force-pushed
the
add-manual-auth0-user-linking
branch
from
4c19692 to
10cc0b9
Compare
brage-andreas
changed the base branch from
graphite-base/2859
to
remove-feide-account-linker-from-terraform
brage-andreas
changed the base branch from
remove-feide-account-linker-from-terraform
to
graphite-base/2859
brage-andreas
force-pushed
the
add-manual-auth0-user-linking
branch
from
10cc0b9 to
a8754ca
Compare
brage-andreas
force-pushed
the
graphite-base/2859
branch
from
dadd38e to
b9ed6c7
Compare
brage-andreas
force-pushed
the
add-manual-auth0-user-linking
branch
from
a8754ca to
7835fa8
Compare
brage-andreas
force-pushed
the
add-manual-auth0-user-linking
branch
4 times, most recently
from
808ca83 to
9c76233
Compare
brage-andreas
force-pushed
the
add-manual-auth0-user-linking
branch
from
9c76233 to
4faefb3
Compare
junlarsen
reviewed
Apr 12, 2026
Comment on lines
+336
to
+343
| for (const membership of memberships) { | ||
| const existing = membershipsByGroup.get(membership.groupId) | ||
| if (existing) { | ||
| existing.push(membership) | ||
| } else { | ||
| membershipsByGroup.set(membership.groupId, [membership]) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I think you can use https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/getOrInsertComputed here for simpler code
| * A--- B-- C-- | ||
| * AB---- BC- | ||
| */ | ||
| export function simplifyGroupMemberships(memberships: GroupMembership[]): GroupMembership[] { |
Member
There was a problem hiding this comment.
Suggested change
| export function simplifyGroupMemberships(memberships: GroupMembership[]): GroupMembership[] { | |
| export function simplifyGroupMemberships(memberships: GroupMembership[]): GroupMembershipWrite[] { |
I think it's better if this function returns a new membership no?
brage-andreas
force-pushed
the
add-manual-auth0-user-linking
branch
from
540a19d to
41b27f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.