Add support for if/then/else conditional schemas#76
Merged
Conversation
0419d43 to
0e291e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds code generation support for JSON Schema
if/then/elsekeywords, which are available in OpenAPI 3.1.Approach
thenor onlyelse): flat-merged into the parent struct as optional fieldsruntime.Conditional[T, E]union wrapper with_Thenand_Elsenamed variant typesWhy
Conditionalinstead ofEitherEitheruses generic.A/.Bfields and.IsA()/.IsB()methods. For if/then/else this is confusing - which one is "then"?Conditionaluses.Then/.Elsefields and.IsThen()/.IsElse()methods, making the semantics immediately clear.Why no
Iffield/method onConditionalGo reserves
ifas a keyword - you can't have a field or method namedIf. More importantly, theifschema is purely a validation predicate (e.g. "if kind equals typeA") and contributes no structural properties to code generation. It's not meaningful at the type level.Limitations:
ifschema is ignored - it's a validation concern, not structuralCloses #74