fix: correct payload structure in code-review-send-labels#8
Open
ArthurHeymans wants to merge 1 commit intodoomelpa:masterfrom
Open
fix: correct payload structure in code-review-send-labels#8ArthurHeymans wants to merge 1 commit intodoomelpa:masterfrom
ArthurHeymans wants to merge 1 commit intodoomelpa:masterfrom
Conversation
The code-review-send-labels method was failing with "Wrong type argument: consp, nil" error when setting labels. The issue was caused by improper alist construction using a-alist function, which could return nil in certain cases. Changes: - Extract label processing into explicit variables for clarity - Use vconcat to ensure label-names is always a vector - Replace a-alist with explicit backquote alist syntax to guarantee proper payload structure - Change let to let* for sequential variable binding The payload now consistently creates ((labels . [vector])) structure that ghub expects, whether labels are present or being cleared. Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code-review-send-labels method was failing with "Wrong type argument: consp, nil" error when setting labels. The issue was caused by improper alist construction using a-alist function, which could return nil in certain cases.
Changes:
The payload now consistently creates ((labels . [vector])) structure that ghub expects, whether labels are present or being cleared.