Skip to content

fix: add Emacs 30 compatibility for closql #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArthurHeymans wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add Emacs 30 compatibility for closql #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions code-review-db.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,18 @@
(require 'uuidgen)
(require 'dash)

;; Emacs 30 compatibility fix for closql.
;; In Emacs 30, `closql--coerce' may return an `eieio--class' struct
;; instead of a class symbol in slot 0 when converting objects to lists.
;; This advice ensures `closql--abbrev-class' receives a symbol.
(when (>= emacs-major-version 30)
(define-advice closql--abbrev-class (:filter-args (args) code-review--handle-class-struct)
"Handle case where class is an eieio--class struct instead of symbol."
(let ((class (car args)))
(list (if (eieio--class-p class)
(eieio--class-name class)
class)))))

(defcustom code-review-db-database-file
(expand-file-name "code-review-db-file.sqlite" user-emacs-directory)
"The file used to store the `code-review' database."
Expand Down