Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for ESM (ECMAScript Module) imports via the jsdelivr provider, enhancing the flexibility of package file handling. The changes include updates to the
README.mdto document the new functionality, modifications to theClientstruct to support ESM mode, and adjustments to the file-fetching logic to accommodate ESM-specific behavior.Documentation Updates:
README.md: Added an example demonstrating how to use the jsdelivr provider with ESM imports, including configuration for specific packages and files.ESM Support in
jsdelivrClient:client/jsdelivr/jsdelivr.go: Added anesmfield to theClientstruct to track ESM mode.client/jsdelivr/jsdelivr.go: Introduced aNewESMfunction to create a client with ESM mode enabled, and aSetESMmethod to toggle ESM mode dynamically.File Fetching Enhancements:
client/jsdelivr/jsdelivr.go: Updated theFetchPackageFilesmethod to include logic for handling ESM imports. When ESM mode is enabled, JavaScript files are replaced with an ESM bundle, while non-JS files (e.g., CSS) are preserved.