Report key errors when parsing config.#84
Open
auouymous wants to merge 1 commit intodonniebreve:mainfrom
Open
Conversation
And show line numbers where errors occur.
donniebreve
requested changes
Oct 1, 2024
| char* buffer = NULL; | ||
| size_t length = 0; | ||
| ssize_t result = -1; | ||
| int lineno = 0; |
Owner
There was a problem hiding this comment.
Suggested change
| int lineno = 0; | |
| int line_number = 0; |
Abbreviations are generally bad for maintenance.
Comment on lines
+101
to
+103
| // Clear existing hyper key | ||
| hyperKey = 0; | ||
|
|
Owner
There was a problem hiding this comment.
Suggested change
| // Clear existing hyper key | |
| hyperKey = 0; | |
| // Clear existing hyper key | |
| hyperKey = 0; |
Removed empty line.
Comment on lines
+4
to
+5
| #define MAX_KEYMAP_CODE 255 | ||
| #define MAX_KEYMAP (MAX_KEYMAP_CODE + 1) |
Owner
There was a problem hiding this comment.
I think there's some cleanup that needs to happen here. MAX_KEYBIT is defined in binding.h, which also dictates the size of the output_device_keystate array. It should probably be moved somewhere more general like keys.h and then used here for the mapping arrays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And show line numbers where errors occur.