Skip to content

Conversation

@Hydrocharged
Copy link
Contributor

@Hydrocharged Hydrocharged commented Nov 13, 2025

@Hydrocharged Hydrocharged requested a review from zachmu November 13, 2025 15:55
@Hydrocharged
Copy link
Contributor Author

Also, right now tests are going to fail since they don't include the noop package so the global interface variable is nil, but that's irrelevant to what should be checked right now.

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General idea is sound, but let's avoid introducing more globals if we can help it

@Hydrocharged Hydrocharged changed the title Hooks example Explicit Analyzer/Builder Overrides Dec 1, 2025
Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main comment is don't put this new information in the context in order to get it to where it needs to go in non-mainline parse contexts. The catalog is a better target for that.

Otherwise I think this plan seems sound.

I think the hooks stuff is harmless enough to leave in with this batch of changes.

Copy link
Member

@zachmu zachmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking a lot better, thanks for the changes.

The only additional structural change you should make is to make ExtensionHook into an interface rather than separate structs with func fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants