Modernized constructors and added return types for PHP compatibility#239
Open
atillavanilla wants to merge 3 commits intodocusign:masterfrom
Open
Modernized constructors and added return types for PHP compatibility#239atillavanilla wants to merge 3 commits intodocusign:masterfrom
atillavanilla wants to merge 3 commits intodocusign:masterfrom
Conversation
WektorPriv
approved these changes
Jul 28, 2025
|
Great, I have an issue right now based on those incompatibilities. Do you know maybe when it would be merged? |
Author
I don’t really know, but if you need any help, I’m happy to lend a hand |
643ff5c to
b9f5dc7
Compare
WektorPriv
approved these changes
Aug 28, 2025
|
Thanks for this PR, when do you think the conflicts can be resolved so we can merge ? |
Author
I will do that now |
Signed-off-by: Moses Olayemi <36492134+moses197@users.noreply.github.com>
Author
conflict resolved |
|
Hi, @prudhvik-docusign is there any chance this change is gonna be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Why It’s Needed
Considerations