Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Advanced Illustration Area schema with a new noArtifact flag and regenerates the language-specific protobuf artifacts that expose that field to consumers of this repository.
Changes:
- Added
noArtifacttoProtoAdvancedIllustrationAreain the source.proto. - Regenerated the aggregated proto plus Go, JS/TS, and C# artifacts to include the new field.
- Updated generated accessors/serialization code so the field is encoded and decoded across supported outputs.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/DocumentElements/documentelements.advanced_illustration_area.proto |
Adds the new source-of-truth field to the AIA message. |
build/docframe.proto |
Regenerated combined proto including the new field. |
docframepb/docframe.pb.go |
Regenerated Go bindings/accessors for the new field. |
build/Docframe.js |
Regenerated JavaScript protobuf runtime support for the new field. |
build/Docframe.d.ts |
Regenerated TypeScript typings for the new field. |
build/Docframe.cs |
Regenerated C# protobuf bindings for the new field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ProtoAdvancedIllustrationAreaTextFlowType textFlow = 9; | ||
| float rotation = 10; | ||
| repeated string comChannelUUIDs = 11; | ||
| bool noArtifact = 12; |
| // versions: | ||
| // protoc-gen-go v1.36.11 | ||
| // protoc v7.34.1 | ||
| // protoc v6.33.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.