Conversation
There was a problem hiding this comment.
Pull request overview
Refactors boot image discovery in src/install.sh so that an already-normalized boot file (e.g. $STORAGE/boot.iso) is reused on container restart instead of being re-moved/re-downloaded, and adds .raw to the list of recognized boot image formats.
Changes:
- Introduces a new
bootFile()helper that setsBOOTdirectly when the source file is already at$STORAGE/boot.$ext(or at/boot.$ext//custom.$ext), and otherwise moves it into place. - Wires
findFile()and the post-download path throughbootFile(), removing the inlinemv/BOOT=logic. - Adds
findFile "boot" "raw"to the boot image search order.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if ! mv -f "$STORAGE/$base" "$dest"; then | ||
| error "Failed to move file to $dest !" && exit 61 | ||
| fi | ||
| ! bootFile "$STORAGE/$base" "$dest" && exit 61 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.