Conversation
Signed-off-by: Johannes Großmann <grossmann.johannes@t-online.de>
Benehiko
approved these changes
Mar 18, 2026
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
This revert PR correctly changes the callback signature from io.ReadWriter to io.ReadWriteCloser across all affected files. The changes are consistent and include an appropriate update to the defer statement that explicitly ignores double-close errors, which is correct given the updated comment explaining that the callback might need to call Close() to unblock pending reads.
Files reviewed:
- plugin/config_test.go
- x/ipc/hijack.go
- x/ipc/hijack_test.go
Findings: No bugs detected in the changed code.
The revert is safe to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got fooled by my own prior comments in the code. So reverting and updating them.