Conversation
Replace deferred and manual clear() calls inside loop bodies with helper methods (loadSecret, tryDecrypt) so that a single defer clear() covers all exit paths per invocation. Also fixes two bugs in store/posixage where defer clear() inside a loop body deferred zeroing until function return rather than end of each iteration. Affected: keychain (darwin/linux/windows), posixage, plugins/pass. Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
Assessment: 🟢 APPROVE
This PR correctly addresses sensitive data cleanup by refactoring defer clear() calls from inside loop bodies into dedicated helper methods. The changes ensure that sensitive byte slices are zeroed on all exit paths.
Key improvements:
- ✅ Fixes two defer-in-loop bugs in
store/posixagewhere clear() was deferred to function return instead of iteration end - ✅ New helper methods (
loadSecret,tryDecrypt) encapsulate sensitive data handling with proper defer clear() placement - ✅ Consistent cleanup pattern across all keychain backends (darwin, linux, windows)
- ✅ All error paths correctly clean up sensitive data before returning
No bugs or regressions identified in the changed code.
Findings
No issues found. The refactoring is sound and improves security hygiene.
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
joe0BAB
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace deferred and manual clear() calls inside loop bodies with helper methods (loadSecret, tryDecrypt) so that a single defer clear() covers all exit paths per invocation. Also fixes two bugs in store/posixage where defer clear() inside a loop body deferred zeroing until function return rather than end of each iteration.
Affected: keychain (darwin/linux/windows), posixage, plugins/pass.