Skip to content

fix(posixage): zero sensitive byte slices after use #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Benehiko merged 1 commit into from
Mar 17, 2026
Merged

fix(posixage): zero sensitive byte slices after use #490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions store/posixage/prompt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ func promptForEncryptionKeys(ctx context.Context, funcs []promptCaller) (map[sec
return nil, err
}
raw = bytes.TrimSpace(raw)
defer clear(raw)
if len(raw) == 0 {
return nil, errors.New("empty key provided on registered callback function")
}
Expand Down
4 changes: 4 additions & 0 deletions store/posixage/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ func (f *fileStore[T]) decryptSecret(ctx context.Context, encryptedSecrets []sec
if err != nil {
return nil, err
}
defer clear(decryptionKey)

identity, err := secretfile.GetIdentity(keyType, string(decryptionKey))
if err != nil {
Expand Down Expand Up @@ -214,6 +215,7 @@ func (f *fileStore[T]) Filter(ctx context.Context, pattern store.Pattern) (map[s
if err != nil {
return err
}
defer clear(decryptedSecret)

secret := f.factory(ctx, id)
if err := secret.SetMetadata(metadata); err != nil {
Expand Down Expand Up @@ -254,6 +256,7 @@ func (f *fileStore[T]) Get(ctx context.Context, id store.ID) (store.Secret, erro
if err != nil {
return nil, err
}
defer clear(decryptedSecret)

secret := f.factory(ctx, id)
if err := secret.SetMetadata(metadata); err != nil {
Expand Down Expand Up @@ -339,6 +342,7 @@ func (f *fileStore[T]) Save(ctx context.Context, id store.ID, s store.Secret) er
if err != nil {
return err
}
defer clear(secret)
metadata := s.Metadata()

var secrets []secretfile.EncryptedSecret
Expand Down
Loading