Support current maintained Node TLS versions: 18, 20, and 22+#33
Merged
Conversation
- Updated `engines.node` to `>=10.16.0` - Updated tsdown.config.ts to target node 10 and strip `node:` import prefix. - Updated `cjs-project` with `main.js` to test node10 support.
- Updated tsdown to target node18 - Updated `engines.node` versions - Updated test-integration projects to work with Node 18.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project to support currently maintained Node.js LTS versions (18, 20, and 22+) instead of only supporting Node 22+. The changes enable better compatibility across different Node.js environments.
- Updated build target configuration to support Node 18
- Modified package.json engine requirements to accept Node 18, 20, and 22+
- Enhanced test integration projects with proper Node 18 compatibility
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tsdown.config.ts | Updated build target to include Node 18 and changed nodeProtocol setting |
| package.json | Changed engine requirements from ">=22.19.0" to support Node 18, 20, and 22+ |
| test-integration/esm-project/package.json | Added tsx dependency and updated test scripts for Node 18 compatibility |
| test-integration/esm-project/main.ts | Added new ESM test file demonstrating Docker SDK usage |
| test-integration/esm-project/.node-version | Set Node version to 18.20.8 for testing |
| test-integration/cjs-project/package.json | Simplified dependencies and added start script |
| test-integration/cjs-project/main.js | Added new CommonJS test file demonstrating Docker SDK usage |
| test-integration/cjs-project/.node-version | Set Node version to 18.20.8 for testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
… removed redundant Docker configurations, and introduced a separate CI matrix for Node 18, 20, and 22.
…ed artifact upload/download, and restructured CI matrix dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Support current maintained Node TLS versions: 18, 20, and 22+. Fixes #24.
- How I did it
engines.nodeversions- How to verify it
Run tests in test-integration/cjs-project and test-integration/esm-project
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)