Skip to content

Always prefer async functions#29

Merged
wmluke merged 2 commits into
docker:mainfrom
ndeloof:Sync
Oct 8, 2025
Merged

Always prefer async functions#29
wmluke merged 2 commits into
docker:mainfrom
ndeloof:Sync

Conversation

@ndeloof

@ndeloof ndeloof commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

- What I did

Avoid use of node's Sync function
close #25

- How I did it

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

@ndeloof ndeloof requested a review from wmluke as a code owner October 8, 2025 14:17
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Comment thread lib/docker-client.ts
…e types/functions needed

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested a review from wmluke October 8, 2025 18:53

@wmluke wmluke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wmluke wmluke merged commit a36c9af into docker:main Oct 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid use of Sync methods

2 participants