implement imageBuild API#20
Merged
Merged
Conversation
ndeloof
force-pushed
the
imagebuild
branch
3 times, most recently
from
e419bb2 to
429a77f
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
implement imageBuild API
- How I did it
/buildAPI returns a stream of json BuildInfo. While other APIs use Title-ized attribbutes, this one uses lower-case ones 🤪. Had to update model template to usebaseNameso we get the raw attribute name as declared in swagger definition.Also moved models to
typepackage, to align with moby- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)