add platform-split parameter#22753
add platform-split parameter#22753ArthurFlag merged 3 commits intodocker:mainfrom ArthurFlag:ENGDOCS-2685-add-platform-split-attribute
platform-split parameter#22753Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
the
area/build
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
Can we have some examples similar to ones in BuildKit README? https://github.com/moby/buildkit?tab=readme-ov-file#local-directory
Like https://docs.docker.com/build/exporters/image-registry/#annotations for image export annotations.
| | Parameter | Type | Default | Description | | ||
| |------------------|---------|---------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | `dest` | String | | Path to copy files to | | ||
| | `platform-split` | Boolean | `false` | With a multi-platform build, a subfolder matching each target platform is created in the destination directory. Set it to `true` to merge files from all platforms into the same directory. | |
There was a problem hiding this comment.
It defaults to true, not false. See example in https://github.com/moby/buildkit?tab=readme-ov-file#local-directory
Also with upcoming moby/buildkit#6007 and opting-in with true it would create the platform dir even if a single platform is being built. Which is not the case atm. So default should be nil in such case (not defined). cc @tonistiigi
There was a problem hiding this comment.
Also this attribute is only supported by the local exporter.
There was a problem hiding this comment.
updated! Let's update the docs with this PR to document the current state of things, I'll update the docs again once the linked bk PR is merged.
2 participants
Description
Parameter was missing.
Related issues or tickets
docker/buildx#3215 (comment)
Reviews