fix: reset thinking flag on agent switch to prevent leaking into non-thinking agents#2161
Closed
dgageot wants to merge 1 commit intodocker:mainfrom
Closed
fix: reset thinking flag on agent switch to prevent leaking into non-thinking agents#2161dgageot wants to merge 1 commit intodocker:mainfrom
dgageot wants to merge 1 commit intodocker:mainfrom
Conversation
…thinking agents When switching agents via Ctrl+N in the TUI, the session's Thinking flag was carried over from the previous agent. This caused Anthropic API errors when switching from a thinking-enabled agent (e.g. Opus with thinking_budget) to one without (e.g. Sonnet with max_tokens=8192), because the thinking budget default (8192) conflicted with max_tokens. Assisted-By: docker-agent
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR correctly fixes a bug where the thinking flag leaked from one agent to another during agent switches, which could cause Anthropic API errors when switching from a thinking-enabled agent to one without thinking configured.
Code Review:
- ✅ The fix properly resets
sess.Thinkingto match the new agent's configuration on agent switch - ✅ Comprehensive test coverage added (
TestAgentSwitch_ResetsThinkingFlag) that validates the fix - ✅ The test correctly simulates switching from Opus (with thinking) to Sonnet (without thinking)
- ✅ The reset behavior is intentional and necessary to prevent API errors
No issues found in the changed code.
gtardif
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When switching agents via Ctrl+N in the TUI, the session's Thinking flag was carried over from the previous agent. This caused Anthropic API errors when switching from a thinking-enabled agent (e.g. Opus with thinking_budget) to one without (e.g. Sonnet with max_tokens=8192), because the thinking budget default (8192) conflicted with max_tokens.
Assisted-By: docker-agent