Skip to content

Remove unused fileWriteTracker from creator package#2157

Merged
dgageot merged 1 commit intodocker:mainfrom
dgageot:board/we-don-t-need-filewritetracker-anymore-i-07f1f5ff
Mar 18, 2026
Merged

Remove unused fileWriteTracker from creator package#2157
dgageot merged 1 commit intodocker:mainfrom
dgageot:board/we-don-t-need-filewritetracker-anymore-i-07f1f5ff

Conversation

@dgageot
Copy link
Member

@dgageot dgageot commented Mar 18, 2026

The fileWriteTracker wrapped the filesystem toolset to track written file paths, but this capability was never consumed in production code. Simplify createToolsetRegistry to use the plain filesystem toolset directly.

Assisted-By: docker-agent

The fileWriteTracker wrapped the filesystem toolset to track written file
paths, but this capability was never consumed in production code.
Simplify createToolsetRegistry to use the plain filesystem toolset directly.

Assisted-By: docker-agent
@dgageot dgageot requested a review from a team as a code owner March 18, 2026 11:16
Copy link

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR removes unused fileWriteTracker code that was never consumed in production. The changes are deletion-only with no new code added, eliminating potential maintenance burden without introducing any bugs.

Summary:

  • ✅ No bugs found in changed code
  • ✅ Clean removal of unused functionality
  • ✅ Tests properly updated to remove related test cases

@dgageot dgageot merged commit 3a90478 into docker:main Mar 18, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants