Remove unused fileWriteTracker from creator package#2157
Merged
dgageot merged 1 commit intodocker:mainfrom Mar 18, 2026
Merged
Conversation
The fileWriteTracker wrapped the filesystem toolset to track written file paths, but this capability was never consumed in production code. Simplify createToolsetRegistry to use the plain filesystem toolset directly. Assisted-By: docker-agent
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR removes unused fileWriteTracker code that was never consumed in production. The changes are deletion-only with no new code added, eliminating potential maintenance burden without introducing any bugs.
Summary:
- ✅ No bugs found in changed code
- ✅ Clean removal of unused functionality
- ✅ Tests properly updated to remove related test cases
gtardif
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fileWriteTracker wrapped the filesystem toolset to track written file paths, but this capability was never consumed in production code. Simplify createToolsetRegistry to use the plain filesystem toolset directly.
Assisted-By: docker-agent