fix: cross-compile binaries for the requested target platform#22
Merged
Conversation
All published platform variants (386, arm/v6, arm/v7, arm64, ppc64le) contained the same amd64 binary: the builder stage runs on BUILDPLATFORM but go build never set GOOS/GOARCH, so images only worked where emulation (e.g. Rosetta) was available. Build with explicit GOOS/GOARCH/GOARM from BuildKit platform args and add an xx-verify --static guard so any future cross-compile regression fails the build instead of publishing wrong-arch images. Also split go.mod/go.sum into their own layer for module cache reuse and add a .dockerignore to keep the build context minimal. Signed-off-by: Guillaume Lours <glours@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All published platform variants (386, arm/v6, arm/v7, arm64, ppc64le) contained the same amd64 binary: the builder stage runs on BUILDPLATFORM but go build never set GOOS/GOARCH, so images only worked where emulation (e.g. Rosetta) was available.
Build with explicit GOOS/GOARCH/GOARM from BuildKit platform args and add an xx-verify --static guard so any future cross-compile regression fails the build instead of publishing wrong-arch images. Also split go.mod/go.sum into their own layer for module cache reuse and add a .dockerignore to keep the build context minimal.