fix: prefer docker login credentials in GitLab CI#7056
Draft
maxpetrusenkoagent wants to merge 1 commit into
Draft
fix: prefer docker login credentials in GitLab CI#7056maxpetrusenkoagent wants to merge 1 commit into
maxpetrusenkoagent wants to merge 1 commit into
Conversation
Signed-off-by: maxpetrusenkoagent <max.petrusenko.agent@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker loginoverDOCKER_AUTH_CONFIGwhen running in GitLab CI.DOCKER_AUTH_CONFIGas a fallback so GitLab Runner-provided read credentials still work before login.Fixes #6156
Test plan
scripts/with-go-mod.sh go test ./cli/config/memorystorescripts/with-go-mod.sh go test ./cli/config/configfilegit diff --checkNote:
scripts/with-go-mod.sh go test ./cli/command/registrycould not complete locally because this machine ran out of space in/tmpduring package compilation (no space left on device).