fix: use actual daemon URL for proxy lookup in SSH connections#7054
Open
vigneshakaviki wants to merge 1 commit into
Open
fix: use actual daemon URL for proxy lookup in SSH connections#7054vigneshakaviki wants to merge 1 commit into
vigneshakaviki wants to merge 1 commit into
Conversation
Previously, SSH connections used a hardcoded dummy host 'http://docker.example.com' for the ConnectionHelper, which meant proxy configuration had to use this dummy URL instead of the actual daemon URL. Now, the actual daemon URL (e.g., 'ssh://user@host.com') is used, allowing users to configure proxies with their actual endpoint URLs in config.json. Before: User configures: {"proxies": {"ssh://user@host.com": {...}}} - doesn't work Only works with: {"proxies": {"http://docker.example.com": {...}}} After: User configures: {"proxies": {"ssh://user@host.com": {...}}} - works! Fixes: docker#7046 Signed-off-by: vigneshakaviki <kumarvignesh295@gmail.com>
8cbe355 to
7b0a2f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When configuring proxies in
~/.docker/config.json, users had to use a hardcoded dummy hosthttp://docker.example.combecause SSH connections used this dummy URL instead of the actual daemon URL.Example that used to fail:
{ "proxies": { "ssh://user@host.com": { "httpProxy": "http://proxy.example.com:3128" } } }Users had to work around this by configuring proxies with the dummy host:
{ "proxies": { "http://docker.example.com": { "httpProxy": "http://proxy.example.com:3128" } } }Solution
Use the actual daemon URL from the endpoint configuration instead of the hardcoded
http://docker.example.com.Now users can configure proxies with their actual SSH endpoint URLs:
{ "proxies": { "ssh://user@host.com": { "httpProxy": "http://proxy.example.com:3128" } } }Changes
daemonURLfor theHostfieldThe fix is minimal and only affects SSH connections, allowing proxy lookup to work with the actual configured endpoint URLs.
Fixes: #7046