Conversation
Signed-off-by: Alano Terblanche <18033717+Benehiko@users.noreply.github.com>
Benehiko
commented
Mar 8, 2024
Benehiko
commented
Mar 8, 2024
Comment on lines
+30
to
+37
| otelShutdown, err := setupOTelSDK(ctx) | ||
| if err != nil { | ||
| return | ||
| } | ||
| // Handle shutdown properly so nothing leaks. | ||
| defer func() { | ||
| otelShutdown(context.Background()) | ||
| }() |
Member
Author
There was a problem hiding this comment.
ignore this. accidental commit
Member
Author
|
Closing this. A lot has changed here and if we see more ctx problems we can address them over time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP and I might still reduce the places where we pass ctx to.
Follow up to #4774 and depends on moby/moby#47518
- What I did
Add more context to each function call.
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)