Skip to content

default to max-retries: 1#102

Merged
derekmisler merged 1 commit intodocker:mainfrom
derekmisler:default-to-max-retries-1
Mar 18, 2026
Merged

default to max-retries: 1#102
derekmisler merged 1 commit intodocker:mainfrom
derekmisler:default-to-max-retries-1

Conversation

@derekmisler
Copy link
Contributor

@derekmisler derekmisler commented Mar 17, 2026

Summary

Changes the max-retries value in review-pr/action.yml from 0 to 1 to handle transient API failures (e.g. Anthropic 400 errors) that previously caused permanent pipeline failures. A single retry is enough to recover from these transient errors without meaningfully increasing the risk of duplicate reviews from full pipeline restarts.

Changes

  • review-pr/action.yml: Updated max-retries from "0" to "1" on the review agent step, with an updated inline comment explaining the rationale.

How to Test

  • Trigger a PR review that hits a transient Anthropic API error and confirm the pipeline retries once and succeeds rather than failing immediately.
  • Trigger a normal PR review and confirm no duplicate reviews are produced.

Closes: https://github.com/docker/gordon/issues/240

Signed-off-by: Derek Misler <derek.misler@docker.com>
@derekmisler
Copy link
Contributor Author

/describe

@derekmisler derekmisler marked this pull request as ready for review March 17, 2026 15:51
@derekmisler derekmisler requested a review from a team as a code owner March 17, 2026 15:51
@docker-agent
Copy link
Contributor

docker-agent bot commented Mar 17, 2026

✅ PR description has been generated and updated!

@derekmisler derekmisler self-assigned this Mar 17, 2026
Copy link
Contributor

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟡 NEEDS ATTENTION

This PR changes the retry behavior for the cagent-action call. The findings below highlight potential risks with the new retry policy.

@derekmisler derekmisler merged commit 971618e into docker:main Mar 18, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants