build: ignore empty BUILDKIT_SYNTAX overrides#3734
Open
crazy-max wants to merge 1 commit intodocker:masterfrom
Open
build: ignore empty BUILDKIT_SYNTAX overrides#3734crazy-max wants to merge 1 commit intodocker:masterfrom
crazy-max wants to merge 1 commit intodocker:masterfrom
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not switch to
gateway.v0whenBUILDKIT_SYNTAXis present but empty. An empty value should not producesource=""and fail with invalid context name errors.Before:
After:
This new error makes sense because
BUILDKIT_SYNTAX=""still reaches BuildKit asbuild-arg:BUILDKIT_SYNTAX=""and treats it as an explicit syntax override, even when the value is empty. This should be fixed in BuildKit.