Add redex#1674
Closed
yongjhih wants to merge 1 commit intodocker-library:masterfrom
Closed
Conversation
Author
|
Build test of #1674; 658cede ( $ bashbrew build "redex"
Cloning redex (git://github.com/yongjhih/docker-redex) ...
Processing redex:latest ...
$ bashbrew list --uniq "$url" | xargs test/run.sh
testing redex:latest
'utc' [1/4]...passed
'cve-2014--shellshock' [2/4]...passed
'no-hard-coded-passwords' [3/4]...passed
'override-cmd' [4/4]...passed |
Member
|
Sorry for the super long tail. The first step we look for is upstream approval/involvement. It looks like upstream just recommends different users' Dockerfiles (facebook/redex/docs/docker.md and facebook/redex#149) and doesn't want to host them. I'd rather not have us pick and promote one of the images without it coming with approval (and maybe involvement) from upstream redex maintainers. They are welcome to adopt the process of being in Docker official-images, or they can stick with the process they already have. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref. facebook/redex#117
Checklist for Review
NOTE: This checklist is intended for the use of the Official Images maintainers both to track the status of your PR and to help inform you and others of where we're at. As such, please leave the "checking" of items to the repository maintainers. If there is a point below for which you would like to provide additional information or note completion, please do so by commenting on the PR. Thanks! (and thanks for staying patient with us ❤️)
foobarneeds Node.js, hasFROM node:...instead of grabbingnodevia other means been considered?)FROM scratch, tarballs only exist in a single commit within the associated history?