-
Notifications
You must be signed in to change notification settings - Fork 5
[fix] 색상 변수 생성 및 적용 #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] 색상 변수 생성 및 적용 #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces Tailwind CSS color variables and updates components to use them, replacing hardcoded hex values.
- Defined reusable color variables in
tailwind.config.js. - Updated header, footer, and button components to use
bg-docker-primary,hover:bg-docker-hover, etc. - Added a hidden
<div>inindex.htmlto force Tailwind to include the new utility classes.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/content_style.css | Added background: #f8f9fa; to <pre> blocks |
| src/scripts/components/header-component.ts | Replaced bg-[#086dd7] with bg-docker-primary (plus inline style) |
| src/scripts/components/footer-component.ts | Replaced bg-[#086dd7] with bg-docker-primary |
| src/scripts/components/button-component.ts | Replaced hex classes with bg-docker-primary and hover:bg-docker-hover |
| index.html | Added hidden <div> to ensure Tailwind picks up new utility classes |
Comments suppressed due to low confidence (1)
src/scripts/components/button-component.ts:24
- The class
text-white!is not a valid Tailwind utility; if you intended to use!important, Tailwind uses a!prefix (e.g.,!text-white). Please correct the class name.
<a href="${href}" class="cursor-pointer py-2 px-4 rounded bg-docker-primary hover:bg-docker-hover text-white!">
| #content pre { | ||
| padding: 0.5rem; | ||
| border: 2px solid #e1e2e6; | ||
| background: #f8f9fa; |
Copilot
AI
Jun 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider using Tailwind’s utility classes or @apply (e.g., @apply bg-background-light;) instead of hardcoding a hex value, to keep styling consistent with the rest of the project.
| background: #f8f9fa; | |
| @apply bg-gray-100; |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
krsy0411
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :D
tailwind.config.js에 색상 변수 정의bg-docker-primary와 같이{적용 위치(배경, 텍스트 등)}-{적용하고자 하는 색}의 형식으로 사용 가능close #146