-
Notifications
You must be signed in to change notification settings - Fork 5
ui : card-component,whats-next,get-docker & translate : whats-next #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ef6c0a0
ui : card-component,whats-next,get-docker & translate : whats-next
g1nya2 383fb27
Merge branch 'g1nya2-ui-translate' of https://github.com/g1nya2/docke…
g1nya2 d332bf5
ui : card-component,whats-next,get-docker & translate : whats-next
g1nya2 3c9aa67
ui : card-component,whats-next,get-docker
g1nya2 2f2c2cf
ui : card-component,whats-next,get-docker
g1nya2 f452562
ui : card-component,whats-next,get-docker
g1nya2 06cb774
프리티어 해결
g1nya2 8a821cf
프리티어 수정
g1nya2 a473594
프리티어 해결
g1nya2 1f772c0
card-component 테스트코드 수정
g1nya2 b8e8626
Update tests/markdown.test.ts
g1nya2 4d2b354
card-component 테스트코드 수정
g1nya2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| class CardComponent extends HTMLElement { | ||
| static get observedAttributes() { | ||
| return ['imgsrc', 'href', 'title', 'description']; | ||
| } | ||
|
|
||
| constructor() { | ||
| super(); | ||
| } | ||
|
|
||
| attributeChangedCallback() { | ||
| this.render(); | ||
| } | ||
|
|
||
| connectedCallback() { | ||
| this.render(); | ||
| } | ||
|
|
||
| render() { | ||
| const imgSrc = this.getAttribute('imgsrc'); // 없으면 null | ||
| const href = this.getAttribute('href') || '#'; | ||
| const title = this.getAttribute('title') || ''; | ||
| const description = this.getAttribute('description') || ''; | ||
|
|
||
| this.innerHTML = ` | ||
| <div class="card"> | ||
| <a href="${href}" class="card-link"> | ||
| ${ | ||
| imgSrc | ||
| ? `<div class="card-icon"> | ||
| <img class="card-img" src="${imgSrc}" alt="${title}" /> | ||
| </div>` | ||
| : '' | ||
| } | ||
| <div class="card-content"> | ||
| <p class="card-description"> | ||
| <strong class="card-title">${title}</strong><br /> | ||
| ${description} | ||
| </p> | ||
| </div> | ||
| </a> | ||
| </div> | ||
| `; | ||
| } | ||
| } | ||
|
|
||
| customElements.define('card-component', CardComponent); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| import './footer-component'; | ||
| import './header-component'; | ||
| import './box-component'; | ||
| import './card-component'; | ||
| import './button-component'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 전역 스타일을 추가한 이유는 뭘까요?
전역 스타일이 필요없다는 건 아닌데, card-comonent랑은 목적이 다른 코드라는 생각이여서요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아니다. 이건 들어가고 제가 좀 더 정리해야할 것 같아요. 머지하겠습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 넵!!